Unit Test for WebView animating in and out of screen

android_webview/browser/test/fake_window.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_BROWSER_TEST_FAKE_WINDOW_H_
 #define ANDROID_WEBVIEW_BROWSER_TEST_FAKE_WINDOW_H_
 
 #include <map>
 
+#include "android_webview/public/browser/draw_gl.h"
 #include "base/memory/weak_ptr.h"
 #include "base/sequence_checker.h"
 #include "base/single_thread_task_runner.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_surface.h"
 
 namespace base {
 class Thread;
 class WaitableEvent;
 }
 
 namespace android_webview {
 
 class BrowserViewRenderer;
 class SharedRendererState;
 
 class WindowHooks {
  public:
   virtual ~WindowHooks() {}
 
   virtual void WillOnDraw() = 0;
   virtual void DidOnDraw(bool success) = 0;
 
   virtual void WillSyncOnRT(SharedRendererState* functor) = 0;
   virtual void DidSyncOnRT(SharedRendererState* functor) = 0;
   virtual void WillProcessOnRT(SharedRendererState* functor) = 0;
   virtual void DidProcessOnRT(SharedRendererState* functor) = 0;
-  virtual void WillDrawOnRT(SharedRendererState* functor) = 0;
+  virtual void SetParentDrawConstraints(AwDrawGLInfo& draw_info) = 0;

[boliu, 2015/03/13 23:51:55]

I'd much rather have SetSurfaceRect, SetTransform etc on FakeWindow then have
this be callbacks.

[hush (inactive), 2015/03/16 18:19:21]

Putting it into fake window make it hard for the rendering test to override and
customize these 2 functions. RenderingTest relies on overriding WindowHooks to
customize FakeWindow behavior. 
If SetParentDrawConstraints is a function on FakeWindow, RenderingTest has no
easy way to call it at the right time, just before the DrawGL because each
DrawGL might have different transforms settable from the rendering test (unless
the specific test creates a subclass of FakeWindow).

But this will over complicate the browser_view_renderer_unittest class. What do
you think?

[boliu, 2015/03/16 20:25:08]

Merge it into WillDrawOnRT?

[hush (inactive), 2015/03/17 18:26:45]

Done.

+  virtual bool WillDrawOnRT(SharedRendererState* functor) = 0;
   virtual void DidDrawOnRT(SharedRendererState* functor) = 0;
+  virtual bool WillWaitForModeDrawToFinish() = 0;

[boliu, 2015/03/13 23:51:55]

This can be a setter too.

[hush (inactive), 2015/03/16 18:19:21]

This bool will be read by both RT and UI in the next patch. So I decide to make
it required in FakeWindow constructor. (default to false.)

[boliu, 2015/03/16 20:25:08]

Ok for now I guess.

The other option is make the instance var UI only, then just pass that bool to
FakeWindow::DrawFunctorOnRT every time.

[hush (inactive), 2015/03/17 18:26:45]

I just removed this flag..

 };
 
 class FakeWindow {
  public:
   FakeWindow(BrowserViewRenderer* view,
              WindowHooks* hooks,
              gfx::Rect location);
   ~FakeWindow();
 
   void Detach();
 
   // BrowserViewRendererClient methods.
   void RequestDrawGL(bool wait_for_completion);
   void PostInvalidate();
+  const gfx::Size& surface_size() { return surface_size_; }
 
  private:
   class ScopedMakeCurrent;
 
   void OnDrawHardware();
   void CheckCurrentlyOnUIThread();
   void CreateRenderThreadIfNeeded();
 
   void InitializeOnRT(base::WaitableEvent* sync);
   void DestroyOnRT(base::WaitableEvent* sync);
@@ skipping 21 matching lines @@
   bool context_current_;
 
   base::WeakPtrFactory<FakeWindow> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeWindow);
 };
 
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_BROWSER_TEST_FAKE_WINDOW_H_