Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1001963002: Reland: Add hpack utilities and perftests to net GN (Closed)

Created:
5 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Add hpack utilities and perftests to net GN This fixes a missed icu import from https://codereview.chromium.org/936313002 so we don't break the win8 GN build. BUG=None TBR=mmenke@chromium.org Committed: https://crrev.com/9c67e5f53d127301b07f9fec2059db36ab3db9dd Cr-Commit-Position: refs/heads/master@{#320352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -8 lines) Patch
M BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 3 chunks +4 lines, -0 lines 0 comments Download
M build/gn_migration.gypi View 6 chunks +7 lines, -8 lines 0 comments Download
M net/BUILD.gn View 4 chunks +82 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
Now actually working on win8 :>
5 years, 9 months ago (2015-03-12 16:57:17 UTC) #2
Dirk Pranke
lgtm
5 years, 9 months ago (2015-03-12 17:38:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001963002/1
5 years, 9 months ago (2015-03-12 19:12:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 20:01:30 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 20:01:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c67e5f53d127301b07f9fec2059db36ab3db9dd
Cr-Commit-Position: refs/heads/master@{#320352}

Powered by Google App Engine
This is Rietveld 408576698