Add GN For hpack fuzzing utilities and net_perftests.

Add GN For hpack fuzzing utilities and net_perftests.

This also adapts net GN targets to use the new size_t->int warning suppression config in //build/config/compiler instead of a locally defined config.

BUG=

Committed: https://crrev.com/707a56a6f0e56138fcef5db3ba7ace1ac3cb83eb
Cr-Commit-Position: refs/heads/master@{#320187}

[Ken Rockot(use gerrit already), 2015-02-19 04:08:05]

rockot@chromium.org changed reviewers:
+ dpranke@chromium.org, mmenke@chromium.org

[Ken Rockot(use gerrit already), 2015-02-19 04:08:06]

mmenke@, could you please take a look at net?
dpranke@ for general GN review

Thanks

[Dirk Pranke, 2015-02-19 05:50:36]

+brettw ...

lgtm, but I think Brett made the same config changes in
https://codereview.chromium.org/929793006/ so you two should coordinate landing
these patches.

[Ken Rockot(use gerrit already), 2015-02-19 18:57:35]

All good, I'll hold off on landing this until that lands.

On Wed, Feb 18, 2015 at 9:50 PM, <dpranke@chromium.org> wrote:

> +brettw ...
>
> lgtm, but I think Brett made the same config changes in
> https://codereview.chromium.org/929793006/ so you two should coordinate
> landing
> these patches.
>
> https://codereview.chromium.org/936313002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mmenke, 2015-02-19 18:58:00]

https://codereview.chromium.org/936313002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/936313002/diff/20001/BUILD.gn#newcode71
BUILD.gn:71: "//net:hpack_fuzz_wrapper",
Should this include net_perftests or hpack_fuzz_mutator?

[Ken Rockot(use gerrit already), 2015-02-19 19:02:07]

On 2015/02/19 18:58:00, mmenke wrote:
> https://codereview.chromium.org/936313002/diff/20001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/936313002/diff/20001/BUILD.gn#newcode71
> BUILD.gn:71: "//net:hpack_fuzz_wrapper",
> Should this include net_perftests or hpack_fuzz_mutator?

I was basing my inclusion of new targets on the gyp_all list in this CL:
https://codereview.chromium.org/901273003/diff/1/BUILD.gn

I don't quite know where that list comes from, but I was assuming it's the set
of all targets we need to get one official builder off the ground. Is that
right, Dirk?

That said, I don't see a problem with adding these targets to :root anyway.

[mmenke, 2015-02-19 19:04:14]

On 2015/02/19 19:02:07, Ken Rockot wrote:
> On 2015/02/19 18:58:00, mmenke wrote:
> > https://codereview.chromium.org/936313002/diff/20001/BUILD.gn
> > File BUILD.gn (right):
> > 
> > https://codereview.chromium.org/936313002/diff/20001/BUILD.gn#newcode71
> > BUILD.gn:71: "//net:hpack_fuzz_wrapper",
> > Should this include net_perftests or hpack_fuzz_mutator?
> 
> I was basing my inclusion of new targets on the gyp_all list in this CL:
> https://codereview.chromium.org/901273003/diff/1/BUILD.gn
> 
> I don't quite know where that list comes from, but I was assuming it's the set
> of all targets we need to get one official builder off the ground. Is that
> right, Dirk?
> 
> That said, I don't see a problem with adding these targets to :root anyway.

I'm fine with not building the targets, if that matches current gyp behavior. 
LGTM.

[Ken Rockot(use gerrit already), 2015-02-19 19:06:46]

Oh right, of course - it's stuff built by all.gyp. Thanks.

On Thu, Feb 19, 2015 at 11:04 AM, <mmenke@chromium.org> wrote:

> On 2015/02/19 19:02:07, Ken Rockot wrote:
>
>> On 2015/02/19 18:58:00, mmenke wrote:
>> > https://codereview.chromium.org/936313002/diff/20001/BUILD.gn
>> > File BUILD.gn (right):
>> >
>> > https://codereview.chromium.org/936313002/diff/20001/BUILD.gn#newcode71
>> > BUILD.gn:71: "//net:hpack_fuzz_wrapper",
>> > Should this include net_perftests or hpack_fuzz_mutator?
>>
>
>  I was basing my inclusion of new targets on the gyp_all list in this CL:
>> https://codereview.chromium.org/901273003/diff/1/BUILD.gn
>>
>
>  I don't quite know where that list comes from, but I was assuming it's
>> the set
>> of all targets we need to get one official builder off the ground. Is that
>> right, Dirk?
>>
>
>  That said, I don't see a problem with adding these targets to :root
>> anyway.
>>
>
> I'm fine with not building the targets, if that matches current gyp
> behavior.
> LGTM.
>
> https://codereview.chromium.org/936313002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2015-02-19 19:37:25]

On 2015/02/19 19:06:46, Ken Rockot wrote:
> Oh right, of course - it's stuff built by all.gyp. Thanks.

Right, it's stuff built by all.gyp. I would expect net_perftests and
hpack_fuzz_mutator to be in the list.

The list in the CL was a work-in-progress, not a 100% correct list. I know there
is stuff still missing.

-- Dirk

[Ken Rockot(use gerrit already), 2015-03-06 17:30:19]

Dirk, can you do a quick sanity check on this rebased patch?

Also: why would a target live in add_to_gn_all rather than gn_all? Or more to
the point, why would a target which builds in GN not just be added to //:gn_all?

[Dirk Pranke, 2015-03-06 18:45:23]

On 2015/03/06 17:30:19, Ken Rockot wrote:
> Dirk, can you do a quick sanity check on this rebased patch?

lgtm.

> Also: why would a target live in add_to_gn_all rather than gn_all? Or more to
> the point, why would a target which builds in GN not just be added to
//:gn_all?

add_to_gn_all goes away as soon as I can land
https://codereview.chromium.org/975123003/

(which actually includes these net targets, so we've duplicated work a bit, but
that's fine; it's
the downside of me not getting a chance to land that patch and not coordinating
work better).

gn_all should build the same targets in both GYP and GN builds.

[Ken Rockot(use gerrit already), 2015-03-06 18:47:29]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2015-03-06 18:47:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/936313002/#ps60001 (title:
"nix net stuff on android")

[commit-bot: I haz the power, 2015-03-06 18:48:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936313002/60001

[commit-bot: I haz the power, 2015-03-06 20:34:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-06 20:34:17]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2015-03-06 20:46:10]

rockot@chromium.org changed reviewers:
+ brettw@chromium.org

[Ken Rockot(use gerrit already), 2015-03-06 20:46:10]

Brett could you please take a look as toplevel OWNER? Thanks!

[Ken Rockot(use gerrit already), 2015-03-11 21:17:41]

ping

[Ken Rockot(use gerrit already), 2015-03-11 21:17:56]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-03-11 21:18:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936313002/60001

[Dirk Pranke, 2015-03-11 21:18:43]

I'm now an owner for that file, so re- lgtm :).

[Ken Rockot(use gerrit already), 2015-03-11 21:22:16]

The CQ bit was unchecked by rockot@chromium.org

[commit-bot: I haz the power, 2015-03-11 21:23:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-11 21:23:07]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Ken Rockot(use gerrit already), 2015-03-11 21:40:47]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2015-03-11 21:40:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/936313002/#ps80001 (title:
"merge")

[commit-bot: I haz the power, 2015-03-11 21:42:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936313002/80001

[commit-bot: I haz the power, 2015-03-11 23:50:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-11 23:54:14]

Patchset 5 (id:??) landed as
https://crrev.com/707a56a6f0e56138fcef5db3ba7ace1ac3cb83eb
Cr-Commit-Position: refs/heads/master@{#320187}

[ananta, 2015-03-12 02:11:54]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1000833002/ by ananta@chromium.org.

The reason for reverting is: This causes a compile failure on the Windows 8 GN
builder

http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/build....