Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 100193005: Add ExtendSelectionAndDelete handler in WebPlugin (Closed)

Created:
7 years ago by kochi
Modified:
7 years ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Add ExtendSelectionAndDelete handler in WebPlugin This ExtendSelectionAndDelete message should be routed to plugin for supporting IME on browser_plugin etc. This is in addition to https://codereview.chromium.org/102963005 (Add supportsInputMethod() interface for WebPlugin) to support IME in WebPlugin. This corresponds to nona's review comment in https://codereview.chromium.org/103403006/#msg14 BUG=235573 TEST=will be covered in content_browsertest R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M Source/web/WebViewImpl.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M public/web/WebPlugin.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kochi
tkent-san, Could you review this? Thanks,
7 years ago (2013-12-12 09:57:26 UTC) #1
tkent
lgtm > This ExtendSelectionAndDelte message should be routed to plugin for Delte -> Delete
7 years ago (2013-12-12 23:34:06 UTC) #2
kochi
On 2013/12/12 23:34:06, tkent wrote: > lgtm > > > This ExtendSelectionAndDelte message should be ...
7 years ago (2013-12-13 01:18:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/100193005/1
7 years ago (2013-12-13 01:19:00 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=16800
7 years ago (2013-12-13 03:50:25 UTC) #5
kochi
7 years ago (2013-12-13 03:59:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r163839 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698