Add supportsInputMethod() interface for WebPlugin.

Add minimal Input Method interface for WebPlugin.

supportsInputMethod() will be used to determine whether
the plugin implementation can handle input method, and
setComposition/confirmComposition corresponds to the same
method in WebViewImpl.cpp, to handle composition text
updates.

This patch is required for Chromium side patch:
https://codereview.chromium.org/103403006/

BUG=235573
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163522

[kochi, 2013-12-10 06:48:37]

tkent-san,

Could you review this?
Or could you suggest any reviewer who can review this part?

Thanks,

[tkent, 2013-12-10 07:22:57]

I think I can review this.

https://codereview.chromium.org/102963005/diff/20001/Source/core/html/HTMLPlu...
File Source/core/html/HTMLPlugInElement.h (right):

https://codereview.chromium.org/102963005/diff/20001/Source/core/html/HTMLPlu...
Source/core/html/HTMLPlugInElement.h:126: bool canHandleInputMethod() const;
This function is not called.

https://codereview.chromium.org/102963005/diff/20001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/102963005/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:2067: WebPlugin* plugin =
getFocusedPluginIfInputMethodSupported();
nit: We can simplify the code like:

if (WebPlugin* plugin = ...)
    return plugin->setComposition(text, underlines, selectionStart,
selectionEnd);

https://codereview.chromium.org/102963005/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:2346: WebPlugin*
WebViewImpl::getFocusedPluginIfInputMethodSupported()
We usually prepend no 'get' to such function.

This doesn't support PluginDocument case. Don't you need to support
PluginDocument?

[kochi, 2013-12-10 08:20:56]

Thanks for the review!

https://codereview.chromium.org/102963005/diff/20001/Source/core/html/HTMLPlu...
File Source/core/html/HTMLPlugInElement.h (right):

https://codereview.chromium.org/102963005/diff/20001/Source/core/html/HTMLPlu...
Source/core/html/HTMLPlugInElement.h:126: bool canHandleInputMethod() const;
On 2013/12/10 07:22:57, tkent wrote:
> This function is not called.
> 

Oops, removed.

https://codereview.chromium.org/102963005/diff/20001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/102963005/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:2067: WebPlugin* plugin =
getFocusedPluginIfInputMethodSupported();
On 2013/12/10 07:22:57, tkent wrote:
> nit: We can simplify the code like:
> 
> if (WebPlugin* plugin = ...)
>     return plugin->setComposition(text, underlines, selectionStart,
> selectionEnd);

Done.

https://codereview.chromium.org/102963005/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:2346: WebPlugin*
WebViewImpl::getFocusedPluginIfInputMethodSupported()
On 2013/12/10 07:22:57, tkent wrote:
> We usually prepend no 'get' to such function.
> 
> This doesn't support PluginDocument case. Don't you need to support
> PluginDocument?

Removed 'get' prefix.

I think I need to support PluginDocument as well.
Added some code.

[tkent, 2013-12-10 08:41:26]

https://codereview.chromium.org/102963005/diff/60001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/102963005/diff/60001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:2346: WebPluginContainerImpl* container =
WebFrameImpl::pluginContainerFromFrame(frame);
Maybe you can use WebFrameImpl::pluginContainerFromNode.

WebPluginContainerImpl* container = WebFrameImpl::pluginContainerFromNode(frame,
WebNode(focusedElement());

[kochi, 2013-12-10 08:48:19]

Thanks for the review!

https://codereview.chromium.org/102963005/diff/60001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/102963005/diff/60001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:2346: WebPluginContainerImpl* container =
WebFrameImpl::pluginContainerFromFrame(frame);
On 2013/12/10 08:41:26, tkent wrote:
> Maybe you can use WebFrameImpl::pluginContainerFromNode.
> 
> WebPluginContainerImpl* container =
WebFrameImpl::pluginContainerFromNode(frame,
> WebNode(focusedElement());

Done.
looks nice.

[tkent, 2013-12-10 08:52:19]

https://codereview.chromium.org/102963005/diff/80001/public/web/WebPlugin.h
File public/web/WebPlugin.h (right):

https://codereview.chromium.org/102963005/diff/80001/public/web/WebPlugin.h#n...
public/web/WebPlugin.h:78: virtual bool supportsInputMethod() const { return
false; }
Because this is a public interface, please add a comment.

https://codereview.chromium.org/102963005/diff/80001/public/web/WebPlugin.h#n...
public/web/WebPlugin.h:132: virtual bool setComposition(const WebString& text,
const WebVector<WebCompositionUnderline>& underlines, int selectionStart, int
selectionEnd) { return false; }
Ditto.

[kochi, 2013-12-10 09:00:01]

https://codereview.chromium.org/102963005/diff/80001/public/web/WebPlugin.h
File public/web/WebPlugin.h (right):

https://codereview.chromium.org/102963005/diff/80001/public/web/WebPlugin.h#n...
public/web/WebPlugin.h:78: virtual bool supportsInputMethod() const { return
false; }
On 2013/12/10 08:52:19, tkent wrote:
> Because this is a public interface, please add a comment.

Done.

https://codereview.chromium.org/102963005/diff/80001/public/web/WebPlugin.h#n...
public/web/WebPlugin.h:132: virtual bool setComposition(const WebString& text,
const WebVector<WebCompositionUnderline>& underlines, int selectionStart, int
selectionEnd) { return false; }
On 2013/12/10 08:52:19, tkent wrote:
> Ditto.

Done.

[tkent, 2013-12-10 09:02:00]

lgtm

[commit-bot: I haz the power, 2013-12-10 09:02:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/102963005/100001

[commit-bot: I haz the power, 2013-12-10 10:09:31]

Change committed as 163522