client/settings.cc - Issue 1001713002: Use new ScopedGeneric move support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/settings.cc

Issue 1001713002: Use new ScopedGeneric move support. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/settings.cc

diff --git a/client/settings.cc b/client/settings.cc

index ca101d2d89dc2ae17cf287381428dace2e5a8f72..b4e5f434b44e12a60e85a46665c585d0774d7df9 100644

--- a/client/settings.cc

+++ b/client/settings.cc

@@ -216,7 +216,7 @@ bool Settings::WriteSettings(FileHandle handle, const Data& data) {

bool Settings::RecoverSettings(FileHandle handle, Data* out_data) {

ScopedFileHandle scoped_handle;

if (handle == kInvalidFileHandle) {

- scoped_handle.reset(OpenForReadingAndWriting().release());

+ scoped_handle = OpenForReadingAndWriting();

handle = scoped_handle.get();

// Test if the file has already been recovered now that the exclusive lock

« no previous file with comments | « no previous file | util/mach/child_port_handshake.cc » ('j') | util/mach/child_port_handshake.cc » ('J')