util/mach/child_port_handshake.cc - Issue 1001713002: Use new ScopedGeneric move support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/mach/child_port_handshake.cc

Issue 1001713002: Use new ScopedGeneric move support. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/mach/child_port_handshake.cc

diff --git a/util/mach/child_port_handshake.cc b/util/mach/child_port_handshake.cc

index b45a7170f2cad361f623a1bac936487a1d0d725b..eedcf47b267fb6e477017fe42bee221c82ce6b38 100644

--- a/util/mach/child_port_handshake.cc

+++ b/util/mach/child_port_handshake.cc

@@ -80,7 +80,7 @@ mach_port_t ChildPortHandshake::RunServer() {

pipe_read_.reset();

// Transfer ownership of the write pipe into this method’s scope.

- base::ScopedFD pipe_write_owner(pipe_write_.release());

+ base::ScopedFD pipe_write_owner = pipe_write_.Pass();

Robert Sesek 2015/03/11 22:44:22 I can revert this one if you prefer the other.

Mark Mentovai 2015/03/12 02:58:27 Robert Sesek wrote:

// Initialize the token and share it with the client via the pipe.

token_ = base::RandUint64();

« no previous file with comments | « client/settings.cc ('k') | no next file » | no next file with comments »