Issue 1001713002: Use new ScopedGeneric move support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1001713002: Use new ScopedGeneric move support. (Closed)

Created:
5 years, 9 months ago by Robert Sesek

Modified:
5 years, 9 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Use new ScopedGeneric move support. BUG=crashpad:14 R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/995e762a4551b91c5cd32fbf6ad21edf50747f85

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	client/settings.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	util/mach/child_port_handshake.cc	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

https://codereview.chromium.org/1001713002/diff/1/util/mach/child_port_handshake.cc File util/mach/child_port_handshake.cc (right): https://codereview.chromium.org/1001713002/diff/1/util/mach/child_port_handshake.cc#newcode83 util/mach/child_port_handshake.cc:83: base::ScopedFD pipe_write_owner = pipe_write_.Pass(); I can revert this one ...

5 years, 9 months ago (2015-03-11 22:44:22 UTC) #1

Mark Mentovai

LGTM https://codereview.chromium.org/1001713002/diff/1/util/mach/child_port_handshake.cc File util/mach/child_port_handshake.cc (right): https://codereview.chromium.org/1001713002/diff/1/util/mach/child_port_handshake.cc#newcode83 util/mach/child_port_handshake.cc:83: base::ScopedFD pipe_write_owner = pipe_write_.Pass(); Robert Sesek wrote: > ...

5 years, 9 months ago (2015-03-12 02:58:27 UTC) #2

Robert Sesek

5 years, 9 months ago (2015-03-12 13:47:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
995e762a4551b91c5cd32fbf6ad21edf50747f85 (presubmit successful).

Expand Messages | Collapse Messages