Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1001683002: MinidumpCrashpadInfo: the default constructor should zero-initialize (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

MinidumpCrashpadInfo: the default constructor should zero-initialize. This regressed in 359bdd86225c when a non-POD UUID data member was added to MinidumpCrashpadInfo, which made MinidumpCrashpadInfo non-POD. This problem seems to have affected MinidumpModuleCodeViewRecordPDB70 since it was added, but it is not likely to have caused any problems there because that structure never appears without having all of its members populated. By comparison, MinidumpCrashpadInfo may be sparsely populated. This caused 4 of the 5 MinidumpCrashpadInfoWriter tests to fail on Windows. TEST=crashpad_minidump_test MinidumpCrashpadInfoWriter.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/94f7f9eeb2e6f6b56ef6546cd0dc720b4b45ce06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M minidump/minidump_extensions.h View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-11 21:39:50 UTC) #2
Robert Sesek
LGTM. Per offline discussion, it's OK for these structs to not be POD. If we ...
5 years, 9 months ago (2015-03-11 21:43:07 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-11 21:43:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94f7f9eeb2e6f6b56ef6546cd0dc720b4b45ce06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698