Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: minidump/minidump_extensions.h

Issue 1001683002: MinidumpCrashpadInfo: the default constructor should zero-initialize (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_extensions.h
diff --git a/minidump/minidump_extensions.h b/minidump/minidump_extensions.h
index b2bb50ebae334c37a1867d48921b0500db0fa5e0..93164186507a45cc058ecfdf2212ccf9db8e7841 100644
--- a/minidump/minidump_extensions.h
+++ b/minidump/minidump_extensions.h
@@ -283,6 +283,16 @@ struct MinidumpModuleCodeViewRecordPDB20 {
//! \sa MinidumpModuleCodeViewRecordPDB20
//! \sa IMAGE_DEBUG_MISC
struct MinidumpModuleCodeViewRecordPDB70 {
+ // UUID has a constructor, which makes it non-POD, which makes this structure
+ // non-POD. In order for the default constructor to zero-initialize other
+ // members, an explicit constructor must be provided.
+ MinidumpModuleCodeViewRecordPDB70()
+ : signature(),
+ uuid(),
+ age(),
+ pdb_name() {
+ }
+
//! \brief The magic number identifying this structure version, stored in
//! #signature.
//!
@@ -444,6 +454,16 @@ struct ALIGNAS(4) PACKED MinidumpModuleCrashpadInfoList {
//! #version, so that newer parsers will be able to determine whether the added
//! fields are valid or not.
struct ALIGNAS(4) PACKED MinidumpCrashpadInfo {
+ // UUID has a constructor, which makes it non-POD, which makes this structure
+ // non-POD. In order for the default constructor to zero-initialize other
+ // members, an explicit constructor must be provided.
+ MinidumpCrashpadInfo()
+ : version(),
+ client_id(),
+ simple_annotations(),
+ module_list() {
+ }
+
//! \brief The structure’s currently-defined version number.
//!
//! \sa version
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698