Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: util/file/file_io_posix.cc

Issue 1001673002: Add Locking calls to file_io.h plus implementations and test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: release load Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/file/file_io.h ('k') | util/file/file_io_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/file/file_io_posix.cc
diff --git a/util/file/file_io_posix.cc b/util/file/file_io_posix.cc
index 60bc9a8daaac1473a1f49c01f76433c77cc7b7e7..2f4709149b0c27a18e9fc28e828d3c062d54e888 100644
--- a/util/file/file_io_posix.cc
+++ b/util/file/file_io_posix.cc
@@ -15,6 +15,7 @@
#include "util/file/file_io.h"
#include <fcntl.h>
+#include <sys/file.h>
#include <unistd.h>
#include "base/files/file_path.h"
@@ -100,6 +101,19 @@ FileHandle LoggingOpenFileForWrite(const base::FilePath& path,
return fd;
}
+bool LoggingLockFile(FileHandle file, FileLocking locking) {
+ int operation = locking == FileLocking::kShared ? LOCK_SH : LOCK_EX;
+ int rv = HANDLE_EINTR(flock(file, operation));
+ PLOG_IF(ERROR, rv != 0) << "flock";
+ return rv == 0;
+}
+
+bool LoggingUnlockFile(FileHandle file) {
+ int rv = flock(file, LOCK_UN);
+ PLOG_IF(ERROR, rv != 0) << "flock";
+ return rv == 0;
+}
+
FileOffset LoggingSeekFile(FileHandle file, FileOffset offset, int whence) {
off_t rv = lseek(file, offset, whence);
PLOG_IF(ERROR, rv < 0) << "lseek";
« no previous file with comments | « util/file/file_io.h ('k') | util/file/file_io_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698