Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: util/file/file_io_posix.cc

Issue 1001673002: Add Locking calls to file_io.h plus implementations and test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: release load Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/file/file_io.h ('k') | util/file/file_io_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/file/file_io.h" 15 #include "util/file/file_io.h"
16 16
17 #include <fcntl.h> 17 #include <fcntl.h>
18 #include <sys/file.h>
18 #include <unistd.h> 19 #include <unistd.h>
19 20
20 #include "base/files/file_path.h" 21 #include "base/files/file_path.h"
21 #include "base/logging.h" 22 #include "base/logging.h"
22 #include "base/numerics/safe_conversions.h" 23 #include "base/numerics/safe_conversions.h"
23 #include "base/posix/eintr_wrapper.h" 24 #include "base/posix/eintr_wrapper.h"
24 25
25 namespace { 26 namespace {
26 27
27 struct ReadTraits { 28 struct ReadTraits {
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 flags |= O_EXCL; 94 flags |= O_EXCL;
94 95
95 int fd = HANDLE_EINTR( 96 int fd = HANDLE_EINTR(
96 open(path.value().c_str(), 97 open(path.value().c_str(),
97 flags, 98 flags,
98 permissions == FilePermissions::kWorldReadable ? 0644 : 0600)); 99 permissions == FilePermissions::kWorldReadable ? 0644 : 0600));
99 PLOG_IF(ERROR, fd < 0) << "open " << path.value(); 100 PLOG_IF(ERROR, fd < 0) << "open " << path.value();
100 return fd; 101 return fd;
101 } 102 }
102 103
104 bool LoggingLockFile(FileHandle file, FileLocking locking) {
105 int operation = locking == FileLocking::kShared ? LOCK_SH : LOCK_EX;
106 int rv = HANDLE_EINTR(flock(file, operation));
107 PLOG_IF(ERROR, rv != 0) << "flock";
108 return rv == 0;
109 }
110
111 bool LoggingUnlockFile(FileHandle file) {
112 int rv = flock(file, LOCK_UN);
113 PLOG_IF(ERROR, rv != 0) << "flock";
114 return rv == 0;
115 }
116
103 FileOffset LoggingSeekFile(FileHandle file, FileOffset offset, int whence) { 117 FileOffset LoggingSeekFile(FileHandle file, FileOffset offset, int whence) {
104 off_t rv = lseek(file, offset, whence); 118 off_t rv = lseek(file, offset, whence);
105 PLOG_IF(ERROR, rv < 0) << "lseek"; 119 PLOG_IF(ERROR, rv < 0) << "lseek";
106 return rv; 120 return rv;
107 } 121 }
108 122
109 bool LoggingCloseFile(FileHandle file) { 123 bool LoggingCloseFile(FileHandle file) {
110 int rv = IGNORE_EINTR(close(file)); 124 int rv = IGNORE_EINTR(close(file));
111 PLOG_IF(ERROR, rv != 0) << "close"; 125 PLOG_IF(ERROR, rv != 0) << "close";
112 return rv == 0; 126 return rv == 0;
113 } 127 }
114 128
115 } // namespace crashpad 129 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/file/file_io.h ('k') | util/file/file_io_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698