Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1001503006: [Webapp Refactor] remoting.ConnectedView (Closed)

Created:
5 years, 9 months ago by kelvinp
Modified:
5 years, 9 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Webapp Refactor] remoting.ConnectedView This CL implements a basic UX control for a connected remote session. DesktopRemoting will augment the functionality that it required through DesktopConnectedView. BUG=465878 Committed: https://crrev.com/9ba1fff0983ed31ddc84444d599be25b56465d5e Cr-Commit-Position: refs/heads/master@{#320200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -207 lines) Patch
M remoting/remoting_webapp_files.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/crd/js/client_session.js View 1 chunk +1 line, -2 lines 0 comments Download
A remoting/webapp/crd/js/connected_view.js View 1 chunk +179 lines, -0 lines 0 comments Download
M remoting/webapp/crd/js/desktop_connected_view.js View 8 chunks +52 lines, -196 lines 0 comments Download
M remoting/webapp/crd/js/session_connector_impl.js View 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kelvinp
PTAL
5 years, 9 months ago (2015-03-11 22:27:15 UTC) #2
garykac
lgtm Please add bug id to desc: BUG=465878
5 years, 9 months ago (2015-03-11 23:02:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001503006/1
5 years, 9 months ago (2015-03-11 23:20:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 01:15:44 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 01:16:17 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9ba1fff0983ed31ddc84444d599be25b56465d5e
Cr-Commit-Position: refs/heads/master@{#320200}

Powered by Google App Engine
This is Rietveld 408576698