Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: remoting/webapp/crd/js/session_connector_impl.js

Issue 1001503006: [Webapp Refactor] remoting.ConnectedView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/desktop_connected_view.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/session_connector_impl.js
diff --git a/remoting/webapp/crd/js/session_connector_impl.js b/remoting/webapp/crd/js/session_connector_impl.js
index 89250f4f2cfaee1764057b3501fb24ceaeda10bb..9fa1770a0e9a14df8e9798572113bf5f1cbec40e 100644
--- a/remoting/webapp/crd/js/session_connector_impl.js
+++ b/remoting/webapp/crd/js/session_connector_impl.js
@@ -356,9 +356,8 @@ remoting.SessionConnectorImpl.prototype.onPluginInitialized_ = function(
remoting.clientSession = this.clientSession_;
this.connectedView_ = new remoting.DesktopConnectedView(
- this.plugin_, this.clientSession_, this.clientContainer_, this.host_,
- this.connectionMode_,
- this.defaultRemapKeys_);
+ this.plugin_, this.clientContainer_, this.host_,
+ this.connectionMode_, this.defaultRemapKeys_);
remoting.desktopConnectedView = this.connectedView_;
this.clientSession_.logHostOfflineErrors(this.logHostOfflineErrors_);
@@ -388,15 +387,11 @@ remoting.SessionConnectorImpl.prototype.removePlugin_ = function() {
this.clientSession_ = null;
remoting.clientSession = null;
- if (this.connectedView_) {
- this.connectedView_.removePlugin();
- }
+ base.dispose(this.connectedView_);
this.connectedView_ = null;
remoting.desktopConnectedView = null;
- if (this.plugin_) {
- this.plugin_.dispose();
- }
+ base.dispose(this.plugin_);
this.plugin_ = null;
};
« no previous file with comments | « remoting/webapp/crd/js/desktop_connected_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698