Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 1001353002: WebSocket ignores trailing whitespace test (Closed)

Created:
5 years, 9 months ago by Adam Rice
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebSocket ignores trailing whitespace test The old WebSocket implementation did not correctly ignore trailing whitespace on response headers. This test ensures that the issue does not regress in the new implementation. BUG=180504 TEST=net_unittests Committed: https://crrev.com/5acb1faf770f6003c9a025ff6ea15ee718e3207a Cr-Commit-Position: refs/heads/master@{#320728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
A net/data/websocket/trailing-whitespace_wsh.py View 1 chunk +27 lines, -0 lines 0 comments Download
M net/websockets/websocket_end_to_end_test.cc View 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Adam Rice
Another regression test. No hurry on this one either.
5 years, 9 months ago (2015-03-13 14:55:12 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm
5 years, 9 months ago (2015-03-16 14:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001353002/1
5 years, 9 months ago (2015-03-16 14:13:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 15:34:09 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 15:35:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5acb1faf770f6003c9a025ff6ea15ee718e3207a
Cr-Commit-Position: refs/heads/master@{#320728}

Powered by Google App Engine
This is Rietveld 408576698