WebSocket ignores trailing whitespace test

net/websockets/websocket_end_to_end_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // End-to-end tests for WebSocket.
 //
 // A python server is (re)started for each test, which is moderately
 // inefficient. However, it makes these tests a good fit for scenarios which
 // require special server configurations.
 
@@ skipping 224 matching lines @@
     context_.Init();
     initialised_context_ = true;
   }
 
   // Send the connect request to |socket_url| and wait for a response. Returns
   // true if the handshake succeeded.
   bool ConnectAndWait(const GURL& socket_url) {
     if (!initialised_context_) {
       InitialiseContext();
     }
-    std::vector<std::string> sub_protocols;
     url::Origin origin("http://localhost");
     event_interface_ = new ConnectTestingEventInterface;
     channel_.reset(
         new WebSocketChannel(make_scoped_ptr(event_interface_), &context_));
-    channel_->SendAddChannelRequest(GURL(socket_url), sub_protocols, origin);
+    channel_->SendAddChannelRequest(GURL(socket_url), sub_protocols_, origin);
     event_interface_->WaitForResponse();
     return !event_interface_->failed();
   }
 
   ConnectTestingEventInterface* event_interface_;  // owned by channel_
   scoped_ptr<TestNetworkDelegateWithProxyInfo> network_delegate_;
   TestURLRequestContext context_;
   scoped_ptr<WebSocketChannel> channel_;
+  std::vector<std::string> sub_protocols_;
   bool initialised_context_;
 };
 
 // None of these tests work on Android.
 // TODO(ricea): Make these tests work on Android. See crbug.com/441711.
 #if defined(OS_ANDROID)
 #define DISABLED_ON_ANDROID(test) DISABLED_##test
 #else
 #define DISABLED_ON_ANDROID(test) test
 #endif
@@ skipping 180 matching lines @@
   InitialiseContext();
   // Set HSTS via wss:
   GURL wss_url = wss_server.GetURL("set-hsts");
   EXPECT_TRUE(ConnectAndWait(wss_url));
 
   // Verify via wss:
   GURL ws_url = ReplaceUrlScheme(wss_server.GetURL(kEchoServer), "ws");
   EXPECT_TRUE(ConnectAndWait(ws_url));
 }
 
+// Regression test for crbug.com/180504 "WebSocket handshake fails when HTTP
+// headers have trailing LWS".
+TEST_F(WebSocketEndToEndTest, DISABLED_ON_ANDROID(TrailingWhitespace)) {
+  SpawnedTestServer ws_server(SpawnedTestServer::TYPE_WS,
+                              SpawnedTestServer::kLocalhost,
+                              GetWebSocketTestDataDirectory());
+  ASSERT_TRUE(ws_server.Start());
+
+  GURL ws_url = ws_server.GetURL("trailing-whitespace");
+  sub_protocols_.push_back("sip");
+  EXPECT_TRUE(ConnectAndWait(ws_url));
+  EXPECT_EQ("sip", event_interface_->selected_subprotocol());
+}
+
 }  // namespace
 
 }  // namespace net