Streams Implementation Update: Reader name and Stream methods

Streams Implementation Update: Reader name and Stream methods

This CL is one of Streams Implementation Update series. This CL does:
 - Rename ExclusiveStreamReader to ReadableStreamReader
 - Remove ReadableStream.read, ReadableStream.ready and ReadableStream.state
   from IDL.

BUG=393911
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192075

[yhirano, 2015-03-13 09:45:06]

yhirano@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2015-03-17 05:14:40]

lgtm

https://codereview.chromium.org/1001233002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js (right):

https://codereview.chromium.org/1001233002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js:63:
streamPromise.then(function(chunks) {
add
test.step_func(

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
File Source/core/streams/ReadableStream.cpp (right):

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.cpp:174: exceptionState.throwTypeError("this
stream is locked to an ReadableStreamReader");
an -> a

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.cpp:200: return
ScriptPromise::reject(scriptState,
V8ThrowException::createTypeError(scriptState->isolate(), "this stream is locked
to an ReadableStreamReader"));
an -> a

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.cpp:263:
exceptionState.throwTypeError("already locked to an ReadableStreamReader");
an -> a

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
File Source/core/streams/ReadableStream.idl (right):

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.idl:10: };
move this to the idl file for the reader?

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
File Source/core/streams/ReadableStreamImpl.h (right):

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStreamImpl.h:22: class ReadableStreamReader;
not used?

[yhirano, 2015-03-17 05:24:15]

https://codereview.chromium.org/1001233002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js (right):

https://codereview.chromium.org/1001233002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js:63:
streamPromise.then(function(chunks) {
On 2015/03/17 05:14:39, tyoshino wrote:
> add
> test.step_func(

We don't need it because we catch the exception afterward.

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
File Source/core/streams/ReadableStream.cpp (right):

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.cpp:174: exceptionState.throwTypeError("this
stream is locked to an ReadableStreamReader");
On 2015/03/17 05:14:39, tyoshino wrote:
> an -> a

Done.

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.cpp:200: return
ScriptPromise::reject(scriptState,
V8ThrowException::createTypeError(scriptState->isolate(), "this stream is locked
to an ReadableStreamReader"));
On 2015/03/17 05:14:40, tyoshino wrote:
> an -> a

Done.

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.cpp:263:
exceptionState.throwTypeError("already locked to an ReadableStreamReader");
On 2015/03/17 05:14:39, tyoshino wrote:
> an -> a

Done.

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
File Source/core/streams/ReadableStream.idl (right):

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.idl:10: };
On 2015/03/17 05:14:40, tyoshino wrote:
> move this to the idl file for the reader?

Done.

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
File Source/core/streams/ReadableStreamImpl.h (right):

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStreamImpl.h:22: class ReadableStreamReader;
On 2015/03/17 05:14:40, tyoshino wrote:
> not used?

Done.

[yhirano, 2015-03-17 05:24:16]

https://codereview.chromium.org/1001233002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js (right):

https://codereview.chromium.org/1001233002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js:63:
streamPromise.then(function(chunks) {
On 2015/03/17 05:14:39, tyoshino wrote:
> add
> test.step_func(

We don't need it because we catch the exception afterward.

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
File Source/core/streams/ReadableStream.cpp (right):

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.cpp:174: exceptionState.throwTypeError("this
stream is locked to an ReadableStreamReader");
On 2015/03/17 05:14:39, tyoshino wrote:
> an -> a

Done.

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.cpp:200: return
ScriptPromise::reject(scriptState,
V8ThrowException::createTypeError(scriptState->isolate(), "this stream is locked
to an ReadableStreamReader"));
On 2015/03/17 05:14:40, tyoshino wrote:
> an -> a

Done.

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.cpp:263:
exceptionState.throwTypeError("already locked to an ReadableStreamReader");
On 2015/03/17 05:14:39, tyoshino wrote:
> an -> a

Done.

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
File Source/core/streams/ReadableStream.idl (right):

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStream.idl:10: };
On 2015/03/17 05:14:40, tyoshino wrote:
> move this to the idl file for the reader?

Done.

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
File Source/core/streams/ReadableStreamImpl.h (right):

https://codereview.chromium.org/1001233002/diff/40001/Source/core/streams/Rea...
Source/core/streams/ReadableStreamImpl.h:22: class ReadableStreamReader;
On 2015/03/17 05:14:40, tyoshino wrote:
> not used?

Done.

[yhirano, 2015-03-17 05:24:49]

yhirano@chromium.org changed reviewers:
+ kouhei@chromium.org

[yhirano, 2015-03-17 05:24:50]

+kouhei for core/core.gypi

[kouhei (in TOK), 2015-03-17 07:04:10]

On 2015/03/17 05:24:50, yhirano wrote:
> +kouhei for core/core.gypi

core.gypi file rename lgtm

[yhirano, 2015-03-17 07:07:19]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2015-03-17 07:07:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org
Link to the patchset: https://codereview.chromium.org/1001233002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-03-17 07:07:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1001233002/60001

[tyoshino (SeeGerritForStatus), 2015-03-17 07:09:37]

https://codereview.chromium.org/1001233002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js (right):

https://codereview.chromium.org/1001233002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js:63:
streamPromise.then(function(chunks) {
On 2015/03/17 05:24:15, yhirano wrote:
> On 2015/03/17 05:14:39, tyoshino wrote:
> > add
> > test.step_func(
> 
> We don't need it because we catch the exception afterward.

True but it's not 'failed to read the response stream: ' but assertion failure.
I'm fine with either but prefer getting AssertionErrors handled by "test".

[yhirano, 2015-03-17 07:10:39]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2015-03-17 07:21:39]

https://codereview.chromium.org/1001233002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js (right):

https://codereview.chromium.org/1001233002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js:63:
streamPromise.then(function(chunks) {
On 2015/03/17 07:09:37, tyoshino wrote:
> On 2015/03/17 05:24:15, yhirano wrote:
> > On 2015/03/17 05:14:39, tyoshino wrote:
> > > add
> > > test.step_func(
> > 
> > We don't need it because we catch the exception afterward.
> 
> True but it's not 'failed to read the response stream: ' but assertion
failure.
> I'm fine with either but prefer getting AssertionErrors handled by "test".

Fixed.

[tyoshino (SeeGerritForStatus), 2015-03-18 05:59:55]

lgtm

[yhirano, 2015-03-18 06:28:17]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2015-03-18 06:28:18]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/1001233002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-03-18 06:29:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1001233002/100001

[commit-bot: I haz the power, 2015-03-18 06:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-18 06:34:47]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)

[yhirano, 2015-03-18 07:24:06]

Patchset #7 (id:120001) has been deleted

[yhirano, 2015-03-18 07:29:50]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2015-03-18 07:29:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/1001233002/#ps120002
(title: "rebase")

[commit-bot: I haz the power, 2015-03-18 07:29:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1001233002/120002

[yhirano, 2015-03-18 07:32:01]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2015-03-18 07:36:58]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2015-03-18 07:37:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/1001233002/#ps150001
(title: " ")

[commit-bot: I haz the power, 2015-03-18 07:37:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1001233002/150001

[commit-bot: I haz the power, 2015-03-18 09:30:06]

Committed patchset #8 (id:150001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192075