Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js

Issue 1001233002: Streams Implementation Update: Reader name and Stream methods (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js
diff --git a/LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js b/LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js
index 544072ab952a52d2257cfaa369d3e0f0e9fa5486..3f966d4c7f22128be5ac0bafdb23ebabcf016a8a 100644
--- a/LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js
+++ b/LayoutTests/http/tests/xmlhttprequest/resources/response-stream.js
@@ -17,17 +17,17 @@ test.step(function() {
var seenStates = [];
- function readStream(stream) {
+ function readStream(reader) {
var chunks = [];
function rec(resolve, reject) {
- while (stream.state === 'readable') {
- chunks.push(stream.read());
+ while (reader.state === 'readable') {
+ chunks.push(reader.read());
}
- if (stream.state === 'closed') {
+ if (reader.state === 'closed') {
resolve(chunks);
return;
}
- stream.ready.then(function() {
+ reader.ready.then(function() {
rec(resolve, reject);
}).catch(reject);
}
@@ -58,23 +58,24 @@ test.step(function() {
assert_true(xhr.response instanceof ReadableStream,
'xhr.response should be ReadableStream during LOADING');
if (streamPromise === undefined) {
- streamPromise = readStream(xhr.response);
+ streamPromise = readStream(xhr.response.getReader());
}
- streamPromise.then(test.step_func(function(chunks) {
+ streamPromise.then(function(chunks) {
assert_equals(xhr.status, 200, 'xhr.status');
// Check that we saw all states.
assert_array_equals(seenStates,
[xhr.OPENED, xhr.HEADERS_RECEIVED, xhr.LOADING, xhr.DONE]);
- assert_equals(xhr.response.state, 'closed', 'stream status');
var size = 0;
for (var i = 0; i < chunks.length; ++i) {
size += chunks[i].byteLength;
}
assert_equals(size, 103746, 'response size');
+ return xhr.response.closed;
+ }).then(function() {
test.done();
- }), test.step_func(function(e) {
- assert_unreached('failed to read the response stream: ' + e);
+ }).catch(test.step_func(function(e) {
+ throw e;
}));
return;

Powered by Google App Engine
This is Rietveld 408576698