Issue 1001153003: ServiceWorker: Reenable "ready" for push messaging browsertest.

Issue 1001153003: ServiceWorker: Reenable "ready" for push messaging browsertest. (Closed)

Created:
5 years, 9 months ago by xiang

Modified:
5 years, 9 months ago

Reviewers:
johnme, falken, Peter Beverloo

CC:
chromium-reviews, peter+watch_chromium.org, johnme+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

ServiceWorker: Reenable "ready" for push messaging browsertest. Reenable "ready" in push messaging browsertest after it was fixed by https://codereview.chromium.org/912443002. BUG=466694 Committed: https://crrev.com/29a9abdb9494499c7afb524a3370f71aa8f00281 Cr-Commit-Position: refs/heads/master@{#320655}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -18 lines)			Patch
	M	chrome/test/data/push_messaging/push_test.js	View		3 chunks	+3 lines, -18 lines	0 comments	Download

Total messages: 9 (2 generated)

johnme

lgtm, thanks (sorry about the slow review - it looked like this patch already had ...

5 years, 9 months ago (2015-03-14 14:34:05 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001153003/1

5 years, 9 months ago (2015-03-14 14:34:14 UTC) #7

commit-bot: I haz the power

5 years, 9 months ago (2015-03-14 16:32:32 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/29a9abdb9494499c7afb524a3370f71aa8f00281
Cr-Commit-Position: refs/heads/master@{#320655}