Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 912443002: ServiceWorker: Make "ready" fetches registration from browser process(3/3). (Closed)

Created:
5 years, 10 months ago by xiang
Modified:
5 years, 9 months ago
CC:
blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Make "ready" fetches registration from browser process(3/3). Cleanup obsolete code, and add layout tests. Remove "ready after unregister" test as an uninstalling registration should be excluded when finding a matched registration. Blink CL: https://codereview.chromium.org/894983002/ Chrome CL: https://codereview.chromium.org/894973003/ BUG=454726, 462529 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191672

Patch Set 1 #

Total comments: 3

Patch Set 2 : add ready after resolve test #

Patch Set 3 : add cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -55 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/ready.html View 1 2 1 chunk +63 lines, -23 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 3 chunks +0 lines, -25 lines 0 comments Download
M public/platform/WebServiceWorkerProviderClient.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
xiang
PTAL, thanks!
5 years, 10 months ago (2015-02-09 08:31:46 UTC) #2
dominicc (has gone to gerrit)
https://codereview.chromium.org/912443002/diff/1/LayoutTests/http/tests/serviceworker/ready.html File LayoutTests/http/tests/serviceworker/ready.html (left): https://codereview.chromium.org/912443002/diff/1/LayoutTests/http/tests/serviceworker/ready.html#oldcode99 LayoutTests/http/tests/serviceworker/ready.html:99: service_worker_unregister_and_register(t, url, scope) Shouldn't all tests start with this, ...
5 years, 10 months ago (2015-02-16 07:19:23 UTC) #3
falken
Can you add a test that after ready was resolved, a later ready won't return ...
5 years, 10 months ago (2015-02-16 09:20:42 UTC) #4
xiang
Thanks for the review, PTAL. A test for access "ready" twice has been added. https://codereview.chromium.org/912443002/diff/1/LayoutTests/http/tests/serviceworker/ready.html ...
5 years, 10 months ago (2015-02-26 08:50:34 UTC) #5
falken
lgtm
5 years, 9 months ago (2015-03-02 02:16:18 UTC) #6
xiang
tkent@ would you please review the public/platform changes? Thanks.
5 years, 9 months ago (2015-03-10 09:01:17 UTC) #9
tkent
public/platform lgtm
5 years, 9 months ago (2015-03-10 09:28:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912443002/60001
5 years, 9 months ago (2015-03-11 01:32:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912443002/60001
5 years, 9 months ago (2015-03-11 01:37:20 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 03:01:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191672

Powered by Google App Engine
This is Rietveld 408576698