Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1000963002: PPC: Simplify pending message object handling. (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
Reviewers:
titzer, Sven Panne, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Simplify pending message object handling. Port d4696c484142c601cbd691ae80164043785a3af7 Original commit message: This moves the decision whether to report a message or not to when the pending exception is propagated instead of trying to preserve the decision in a ThreadLocalTop field. R=titzer@chromium.org Review URL: https://codereview.chromium.org/998943003 Cr-Commit-Position: refs/heads/master@{#27150} R=danno@chromium.org, svenpanne@chromium.org, titzer@chromium.org BUG= Committed: https://crrev.com/ae78a9702a9e33007e93f79dadfade5c2f22ff14 Cr-Commit-Position: refs/heads/master@{#27173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M src/ppc/full-codegen-ppc.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
michael_dawson
PPC port for d4696c484142c601cbd691ae80164043785a3af7 Simplify pending message object handling.
5 years, 9 months ago (2015-03-12 15:30:14 UTC) #1
titzer
lgtm
5 years, 9 months ago (2015-03-12 15:38:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000963002/1
5 years, 9 months ago (2015-03-13 07:11:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 07:34:52 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 07:35:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae78a9702a9e33007e93f79dadfade5c2f22ff14
Cr-Commit-Position: refs/heads/master@{#27173}

Powered by Google App Engine
This is Rietveld 408576698