Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 998943003: Simplify pending message object handling. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify pending message object handling. This moves the decision whether to report a message or not to when the pending exception is propagated instead of trying to preserve the decision in a ThreadLocalTop field. R=titzer@chromium.org Committed: https://crrev.com/d4696c484142c601cbd691ae80164043785a3af7 Cr-Commit-Position: refs/heads/master@{#27150}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -101 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 2 chunks +3 lines, -18 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/isolate.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/isolate.cc View 1 4 chunks +26 lines, -23 lines 0 comments Download
M src/serialize.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-11 18:13:56 UTC) #1
titzer
LGTM love red https://codereview.chromium.org/998943003/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/998943003/diff/1/src/isolate.cc#newcode1407 src/isolate.cc:1407: // propagation was unsuccessful, then we ...
5 years, 9 months ago (2015-03-11 18:17:10 UTC) #2
Michael Starzinger
Thanks. https://codereview.chromium.org/998943003/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/998943003/diff/1/src/isolate.cc#newcode1407 src/isolate.cc:1407: // propagation was unsuccessful, then we will get ...
5 years, 9 months ago (2015-03-11 18:35:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998943003/20001
5 years, 9 months ago (2015-03-12 09:30:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-12 09:50:35 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 09:50:53 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4696c484142c601cbd691ae80164043785a3af7
Cr-Commit-Position: refs/heads/master@{#27150}

Powered by Google App Engine
This is Rietveld 408576698