[Android] Incorporate findbugs into android builds.

build/java.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file is meant to be included into a target to provide a rule
 # to build Java in a consistent manner.
 #
 # To use this, create a gyp target with the following form:
 # {
 #   'target_name': 'my-package_java',
@@ skipping 59 matching lines @@
     'res_extra_dirs': [],
     'res_extra_files': [],
     'res_v14_verify_only%': 0,
     'resource_input_paths': ['>@(res_extra_files)'],
     'intermediate_dir': '<(SHARED_INTERMEDIATE_DIR)/<(_target_name)',
     'compile_stamp': '<(intermediate_dir)/compile.stamp',
     'lint_stamp': '<(intermediate_dir)/lint.stamp',
     'lint_result': '<(intermediate_dir)/lint_result.xml',
     'lint_config': '<(intermediate_dir)/lint_config.xml',
     'never_lint%': 0,
+    'findbugs_stamp': '<(intermediate_dir)/findbugs.stamp',
+    'run_findbugs%': 1,
     'proguard_config%': '',
     'proguard_preprocess%': '0',
     'variables': {
       'variables': {
         'proguard_preprocess%': 0,
         'emma_never_instrument%': 0,
       },
       'conditions': [
         ['proguard_preprocess == 1', {
           'javac_jar_path': '<(intermediate_dir)/<(_target_name).pre.jar'
@@ skipping 120 matching lines @@
             'python', '<(DEPTH)/build/android/gyp/proguard.py',
             '--proguard-path=<(android_sdk_root)/tools/proguard/lib/proguard.jar',
             '--input-path=<(javac_jar_path)',
             '--output-path=<(jar_path)',
             '--proguard-config=<(proguard_config)',
             '--classpath=<(android_sdk_jar) >(input_jars_paths)',
           ]
         },
       ],
     }],
+    ['run_findbugs == 1', {
+      'actions': [
+        {
+          'action_name': 'findbugs_<(_target_name)',
+          'message': 'Running findbugs on <(_target_name)',
+          'inputs': [
+            '<(DEPTH)/build/android/findbugs_diff.py',
+            '<(DEPTH)/build/android/findbugs_filter/findbugs_exclude.xml',
+            '<(DEPTH)/build/android/pylib/utils/findbugs.py',

[cjhopman, 2015/03/12 19:22:43]

This should also include >@(input_jars_paths) i think

[jbudorick, 2015/03/13 13:12:20]

yep, it should. done.

+            '<(jar_final_path)',
+            '<(compile_stamp)',
+          ],
+          'outputs': [
+            '<(findbugs_stamp)',
+          ],
+          'action': [
+            'python', '<(DEPTH)/build/android/findbugs_diff.py',
+            '--auxclasspath-gyp', '>(input_jars_paths)',
+            '--stamp', '<(findbugs_stamp)',
+            '<(jar_final_path)',
+          ],
+        },
+      ],
+    }],
   ],
   'actions': [
     {
       'action_name': 'javac_<(_target_name)',
       'message': 'Compiling <(_target_name) java sources',
       'variables': {
         'java_sources': ['>!@(find >(java_in_dir)/src >(additional_src_dirs) -name "*.java")'],
       },
       'inputs': [
         '<(DEPTH)/build/android/gyp/util/build_utils.py',
@@ skipping 77 matching lines @@
       'action_name': 'dex_<(_target_name)',
       'variables': {
         'conditions': [
           ['emma_instrument != 0', {
             'dex_no_locals': 1,
           }],
         ],
         'dex_input_paths': [ '<(jar_final_path)' ],
         'output_path': '<(dex_path)',
       },
+      'inputs': [

[cjhopman, 2015/03/12 19:22:43]

Is this required? I believe that gyp will create a stamp build target that
depends on all of the internal actions finishing (so that anytime this target is
built, lint/findbugs will run if necessary). I could be wrong about that,
though.

[jbudorick, 2015/03/13 13:12:19]

No, it isn't. In fact, builds locally seem to be going faster without it...
maybe introducing this was why my builds were so slow?

+        '<(findbugs_stamp)',
+        '<(lint_stamp)',
+      ],
       'includes': [ 'android/dex_action.gypi' ],
     },
   ],
 }