android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

index 0cc8d226e0f6298b0e02207eb509b084c765cdd8..650c19478ed7f1e56d39c3f2613cc5a9d5373fc1 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

@@ -46,6 +46,7 @@ import org.chromium.android_webview.JsResultReceiver;

import org.chromium.android_webview.permission.AwPermissionRequest;

import org.chromium.base.ThreadUtils;

import org.chromium.base.TraceEvent;

+import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewClient;

import org.chromium.content.browser.ContentViewCore;

@@ -1203,6 +1204,7 @@ public class WebViewContentsClientAdapter extends AwContentsClient {

return mAwPermissionRequest.getOrigin();

}

+ @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_THIS")

@Override

public String[] getResources() {

synchronized (this) {