Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package com.android.webview.chromium; 5 package com.android.webview.chromium;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 import android.graphics.Bitmap; 8 import android.graphics.Bitmap;
9 import android.graphics.BitmapFactory; 9 import android.graphics.BitmapFactory;
10 import android.graphics.Canvas; 10 import android.graphics.Canvas;
(...skipping 28 matching lines...) Expand all
39 39
40 import org.chromium.android_webview.AwContentsClient; 40 import org.chromium.android_webview.AwContentsClient;
41 import org.chromium.android_webview.AwContentsClientBridge; 41 import org.chromium.android_webview.AwContentsClientBridge;
42 import org.chromium.android_webview.AwHttpAuthHandler; 42 import org.chromium.android_webview.AwHttpAuthHandler;
43 import org.chromium.android_webview.AwWebResourceResponse; 43 import org.chromium.android_webview.AwWebResourceResponse;
44 import org.chromium.android_webview.JsPromptResultReceiver; 44 import org.chromium.android_webview.JsPromptResultReceiver;
45 import org.chromium.android_webview.JsResultReceiver; 45 import org.chromium.android_webview.JsResultReceiver;
46 import org.chromium.android_webview.permission.AwPermissionRequest; 46 import org.chromium.android_webview.permission.AwPermissionRequest;
47 import org.chromium.base.ThreadUtils; 47 import org.chromium.base.ThreadUtils;
48 import org.chromium.base.TraceEvent; 48 import org.chromium.base.TraceEvent;
49 import org.chromium.base.annotations.SuppressFBWarnings;
49 import org.chromium.content.browser.ContentView; 50 import org.chromium.content.browser.ContentView;
50 import org.chromium.content.browser.ContentViewClient; 51 import org.chromium.content.browser.ContentViewClient;
51 import org.chromium.content.browser.ContentViewCore; 52 import org.chromium.content.browser.ContentViewCore;
52 53
53 import java.lang.ref.WeakReference; 54 import java.lang.ref.WeakReference;
54 import java.security.Principal; 55 import java.security.Principal;
55 import java.security.PrivateKey; 56 import java.security.PrivateKey;
56 import java.security.cert.X509Certificate; 57 import java.security.cert.X509Certificate;
57 import java.util.ArrayList; 58 import java.util.ArrayList;
58 import java.util.HashMap; 59 import java.util.HashMap;
(...skipping 1137 matching lines...) Expand 10 before | Expand all | Expand 10 after
1196 public PermissionRequestAdapter(AwPermissionRequest awPermissionRequest) { 1197 public PermissionRequestAdapter(AwPermissionRequest awPermissionRequest) {
1197 assert awPermissionRequest != null; 1198 assert awPermissionRequest != null;
1198 mAwPermissionRequest = awPermissionRequest; 1199 mAwPermissionRequest = awPermissionRequest;
1199 } 1200 }
1200 1201
1201 @Override 1202 @Override
1202 public Uri getOrigin() { 1203 public Uri getOrigin() {
1203 return mAwPermissionRequest.getOrigin(); 1204 return mAwPermissionRequest.getOrigin();
1204 } 1205 }
1205 1206
1207 @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_THIS")
1206 @Override 1208 @Override
1207 public String[] getResources() { 1209 public String[] getResources() {
1208 synchronized (this) { 1210 synchronized (this) {
1209 if (mResources == null) { 1211 if (mResources == null) {
1210 mResources = toPermissionResources(mAwPermissionRequest.getR esources()); 1212 mResources = toPermissionResources(mAwPermissionRequest.getR esources());
1211 } 1213 }
1212 return mResources; 1214 return mResources;
1213 } 1215 }
1214 } 1216 }
1215 1217
1216 @Override 1218 @Override
1217 public void grant(String[] resources) { 1219 public void grant(String[] resources) {
1218 long requestedResource = mAwPermissionRequest.getResources(); 1220 long requestedResource = mAwPermissionRequest.getResources();
1219 if ((requestedResource & toAwPermissionResources(resources)) == requ estedResource) 1221 if ((requestedResource & toAwPermissionResources(resources)) == requ estedResource)
1220 mAwPermissionRequest.grant(); 1222 mAwPermissionRequest.grant();
1221 else 1223 else
1222 mAwPermissionRequest.deny(); 1224 mAwPermissionRequest.deny();
1223 } 1225 }
1224 1226
1225 @Override 1227 @Override
1226 public void deny() { 1228 public void deny() {
1227 mAwPermissionRequest.deny(); 1229 mAwPermissionRequest.deny();
1228 } 1230 }
1229 } 1231 }
1230 } 1232 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698