components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add gn option, address Yaron's comment, rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/findbugs_diff.py ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java

index 6c6eaca81d40f5d5bb2782f2ec1cbfc64e3b72f3..c6242daf586bfa7ba4dcf481deff272944c02087 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java

@@ -7,6 +7,7 @@ package org.chromium.net;

import android.test.suitebuilder.annotation.LargeTest;

import android.test.suitebuilder.annotation.SmallTest;

+import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.base.test.util.Feature;

import java.io.IOException;

@@ -252,6 +253,7 @@ public class MockUrlRequestJobTest extends CronetTestBase {

}

+ @SuppressFBWarnings("DLS_DEAD_LOCAL_STORE")

@SmallTest

@Feature({"Cronet"})

public void testNoWriteAfterSyncCancel() throws Exception {