chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add gn option, address Yaron's comment, rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/findbugs_diff.py ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/RestoreMigrateTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java

index 4b8d26e807fac27139cffb040a931be916198bfa..363093c372178b8b94fbd7d72136b23c04ead0b9 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java

@@ -12,7 +12,6 @@ import org.chromium.base.ThreadUtils;

import org.chromium.base.test.util.Feature;

import org.chromium.chrome.R;

import org.chromium.chrome.shell.ChromeShellActivity;

-import org.chromium.chrome.shell.ChromeShellApplication;

import org.chromium.chrome.shell.ChromeShellTestBase;

/**

@@ -30,8 +29,6 @@ public class AddToHomescreenDialogTest extends ChromeShellTestBase {

public void setUp() throws Exception {

super.setUp();

mActivity = launchChromeShellWithBlankPage();

- ChromeShellApplication application =

- (ChromeShellApplication) mActivity.getApplication();

}

@SmallTest