android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add gn option, address Yaron's comment, rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java ('k') | android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java » ('j') | build/android/findbugs_diff.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

index b96e35ef57587740a80e33e0f51d2853ed0c912a..dd543d56cda4cd08255b7d90db7209ccb0ef1296 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

@@ -46,6 +46,7 @@ import org.chromium.android_webview.AwContentsStatics;

import org.chromium.android_webview.AwPrintDocumentAdapter;

import org.chromium.android_webview.AwSettings;

import org.chromium.base.ThreadUtils;

+import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.content.browser.SmartClipProvider;

import java.io.BufferedWriter;

@@ -1141,6 +1142,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate

mAwContents.findAllAsync(searchString);

}

+ @SuppressFBWarnings("RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE")

@Override

public boolean showFindDialog(final String text, final boolean showIme) {

mFactory.startYourEngines(false);