android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add gn option, address Yaron's comment, rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java ('k') | android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java » ('j') | build/android/findbugs_diff.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java

index 44853daf96278e82b8f2900a326e848474e9ea46..5a93abc9c4f0a9e203b64270c34e1ff5fdcc20cf 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java

@@ -7,6 +7,7 @@ package com.android.webview.chromium;

import android.graphics.Bitmap;

import android.webkit.WebHistoryItem;

+import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.content_public.browser.NavigationEntry;

/**

@@ -79,6 +80,9 @@ public class WebHistoryItemChromium extends WebHistoryItem {

/**

* See {@link android.webkit.WebHistoryItem#clone}.

+ @SuppressFBWarnings({

+ "CHROMIUM_SYNCHRONIZED_METHOD",

+ "CN_IDIOM_NO_SUPER_CALL"})

@Override

public synchronized WebHistoryItemChromium clone() {

return new WebHistoryItemChromium(mUrl, mOriginalUrl, mTitle, mFavicon);