Issue 1000653002: test::Multiprocess: exit cleanly from children with _exit()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1000653002: test::Multiprocess: exit cleanly from children with _exit() (Closed)

Created:
5 years, 9 months ago by Mark Mentovai

Modified:
5 years, 9 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

test::Multiprocess: exit cleanly from children with _exit(). Child exits were using exit(), which caused crashes on 10.10 for Multiprocess-based tests that ran after HTTPTransport tests. The crashes occurred while running exit-time destructors. exit() was never correct in this situation, this should have used _exit() all along. TEST=crashpad_util_test BUG=crashpad:17 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b8cbfff0d35ee41e9afd42ba1e4119f4b4bd6504

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	util/test/multiprocess.h	View		2 chunks	+8 lines, -3 lines	0 comments	Download
	M	util/test/multiprocess_posix.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

5 years, 9 months ago (2015-03-11 17:59:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b8cbfff0d35ee41e9afd42ba1e4119f4b4bd6504 (presubmit successful).