Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: util/test/multiprocess_posix.cc

Issue 1000653002: test::Multiprocess: exit cleanly from children with _exit() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/test/multiprocess.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 MultiprocessChild(); 205 MultiprocessChild();
206 206
207 info_->pipe_c2p_write.reset(); 207 info_->pipe_c2p_write.reset();
208 info_->pipe_p2c_read.reset(); 208 info_->pipe_p2c_read.reset();
209 209
210 if (testing::Test::HasFailure()) { 210 if (testing::Test::HasFailure()) {
211 // Trigger the ScopedForbidReturn destructor. 211 // Trigger the ScopedForbidReturn destructor.
212 return; 212 return;
213 } 213 }
214 214
215 exit(0); 215 // In a forked child, exit() is unsafe. Use _exit() instead.
216 _exit(EXIT_SUCCESS);
216 } 217 }
217 218
218 } // namespace test 219 } // namespace test
219 } // namespace crashpad 220 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/test/multiprocess.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698