Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1000443002: [Extensions] Make value_builder.h usable outside of tests. (Closed)

Created:
5 years, 9 months ago by not at google - send to devlin
Modified:
5 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Make value_builder.h usable outside of tests. R=rockot@chromium.org Committed: https://crrev.com/4357acb8dea4f61f6681f4c837faeb66ea8c9087 Cr-Commit-Position: refs/heads/master@{#319980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/chromeos/extensions/input_method_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/extensions.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
not at google - send to devlin
Keep being sad seeing code like: https://codereview.chromium.org/987583004/diff/20001/chrome/browser/extensions/api/tabs/tabs_event_router.cc?context=&column_width=80&tab_spaces=8 this will help improve that. Btw removing the ...
5 years, 9 months ago (2015-03-10 19:43:03 UTC) #1
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-03-10 19:56:43 UTC) #2
Ken Rockot(use gerrit already)
On 2015/03/10 19:43:03, kalman wrote: > Btw removing the include in the api.cc because it's ...
5 years, 9 months ago (2015-03-10 19:57:02 UTC) #3
not at google - send to devlin
On 2015/03/10 19:57:02, Ken Rockot wrote: > On 2015/03/10 19:43:03, kalman wrote: > > > ...
5 years, 9 months ago (2015-03-10 19:57:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000443002/1
5 years, 9 months ago (2015-03-10 19:57:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 21:43:02 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 21:44:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4357acb8dea4f61f6681f4c837faeb66ea8c9087
Cr-Commit-Position: refs/heads/master@{#319980}

Powered by Google App Engine
This is Rietveld 408576698