Issue 996053003: Use Map.addAll() where possible in the resolver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 996053003: Use Map.addAll() where possible in the resolver. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Use Map.addAll() where possible in the resolver. I accidentally bumped into it and found out that Map.addAll() was added since the (first?) translation. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44442

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	pkg/analyzer/lib/src/generated/resolver.dart	View		3 chunks	+3 lines, -7 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/996053003/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/996053003/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode9362 pkg/analyzer/lib/src/generated/resolver.dart:9362: void _addAllFromMap( Shouldn't we just get rid of ...

5 years, 9 months ago (2015-03-12 18:59:44 UTC) #2

scheglov

5 years, 9 months ago (2015-03-12 21:38:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44442 (presubmit successful).

Expand Messages | Collapse Messages