Use Map.addAll() where possible in the resolver.

pkg/analyzer/lib/src/generated/resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.resolver;
 
 import "dart:math" as math;
 import 'dart:collection';
 
 import 'package:analyzer/src/generated/utilities_collection.dart';
@@ skipping 9341 matching lines @@
     }
     return new Namespace(definedNames);
   }
 
   /**
    * Add all of the names in the given namespace to the given mapping table.
    *
    * @param definedNames the mapping table to which the names in the given namespace are to be added
    * @param namespace the namespace containing the names to be added to this namespace
    */
   void _addAllFromMap(

[Brian Wilkerson, 2015/03/12 18:59:44]

Shouldn't we just get rid of this helper method?

       Map<String, Element> definedNames, Map<String, Element> newNames) {
-    newNames.forEach((String name, Element element) {
-      definedNames[name] = element;
-    });
+    definedNames.addAll(newNames);
   }
 
   /**
    * Add all of the names in the given namespace to the given mapping table.
    *
    * @param definedNames the mapping table to which the names in the given namespace are to be added
    * @param namespace the namespace containing the names to be added to this namespace
    */
   void _addAllFromNamespace(
       Map<String, Element> definedNames, Namespace namespace) {
     if (namespace != null) {
-      _addAllFromMap(definedNames, namespace.definedNames);
+      definedNames.addAll(namespace.definedNames);
     }
   }
 
   /**
    * Add the given element to the given mapping table if it has a publicly visible name.
    *
    * @param definedNames the mapping table to which the public name is to be added
    * @param element the element to be added
    */
   void _addIfPublic(Map<String, Element> definedNames, Element element) {
@@ skipping 3503 matching lines @@
    * @param outerScope the outer scope in which types might be overridden
    */
   TypeOverrideManager_TypeOverrideScope(this._outerScope);
 
   /**
    * Apply a set of overrides that were previously captured.
    *
    * @param overrides the overrides to be applied
    */
   void applyOverrides(Map<VariableElement, DartType> overrides) {
-    overrides.forEach((VariableElement element, DartType type) {
-      _overridenTypes[element] = type;
-    });
+    _overridenTypes.addAll(overrides);
   }
 
   /**
    * Return a table mapping the elements whose type is overridden in the current scope to the
    * overriding type.
    *
    * @return the overrides in the current scope
    */
   Map<VariableElement, DartType> captureLocalOverrides() => _overridenTypes;
 
@@ skipping 2478 matching lines @@
    * library.
    */
   final HashSet<String> members = new HashSet<String>();
 
   /**
    * Names of resolved or unresolved class members that are read in the
    * library.
    */
   final HashSet<String> readMembers = new HashSet<String>();
 }