Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 993613002: Implement 'print', 'up', 'down', and 'frame' commands in the Observatory debugger. (Closed)

Created:
5 years, 9 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Implement 'print', 'up', 'down', and 'frame' commands in the Observatory debugger. Implement in-frame evaluation in the vm service. Add a notion of 'current frame' and use it across the debugger, particularly in source-location based commands (break, clear). Change the expansion logic for frames, so that by default only the current frame is shown. When a user expands a frame it is now pinned. Change command line parsing so that internal whitespace is preserved. We need this to properly evaluate expressions with internal whitespace. Fix a deadlock in the debugger message loop. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44353

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : code review #

Patch Set 4 : fix deadlock, etc. #

Total comments: 1

Patch Set 5 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -98 lines) Patch
M runtime/bin/dbg_message.cc View 1 2 3 1 chunk +8 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/server.dart View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/service_common.dart View 1 2 3 3 chunks +12 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/cli/command.dart View 3 chunks +22 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/debugger/debugger.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/debugger/source_location.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 2 12 chunks +246 lines, -17 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 7 chunks +10 lines, -8 lines 0 comments Download
M runtime/observatory/test/command_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/test/debugging_test.dart View 1 2 3 3 chunks +21 lines, -9 lines 0 comments Download
M runtime/observatory/test/source_location_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/json_stream.cc View 1 2 3 1 chunk +10 lines, -5 lines 0 comments Download
M runtime/vm/message_handler.cc View 1 2 3 3 chunks +7 lines, -3 lines 0 comments Download
M runtime/vm/service.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 2 3 10 chunks +46 lines, -8 lines 0 comments Download
M runtime/vm/service/client.dart View 1 2 3 1 chunk +10 lines, -6 lines 0 comments Download
M runtime/vm/service/message.dart View 1 2 3 4 6 chunks +18 lines, -14 lines 0 comments Download
M runtime/vm/service_isolate.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 9 months ago (2015-03-09 17:37:20 UTC) #2
Cutch
LGTMwC https://codereview.chromium.org/993613002/diff/20001/runtime/observatory/lib/src/elements/debugger.dart File runtime/observatory/lib/src/elements/debugger.dart (right): https://codereview.chromium.org/993613002/diff/20001/runtime/observatory/lib/src/elements/debugger.dart#newcode150 runtime/observatory/lib/src/elements/debugger.dart:150: debugger.currentFrame -= count; Should you notify the user ...
5 years, 9 months ago (2015-03-09 17:43:49 UTC) #3
Cutch
lgtm https://codereview.chromium.org/993613002/diff/60001/runtime/vm/service/message.dart File runtime/vm/service/message.dart (right): https://codereview.chromium.org/993613002/diff/60001/runtime/vm/service/message.dart#newcode98 runtime/vm/service/message.dart:98: 'message': 'could not send message to isolate', might ...
5 years, 9 months ago (2015-03-10 00:00:18 UTC) #4
turnidge
5 years, 9 months ago (2015-03-10 00:08:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 44353 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698