Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: runtime/observatory/lib/service_common.dart

Issue 993613002: Implement 'print', 'up', 'down', and 'frame' commands in the Observatory debugger. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/server.dart ('k') | runtime/observatory/lib/src/cli/command.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/service_common.dart
diff --git a/runtime/observatory/lib/service_common.dart b/runtime/observatory/lib/service_common.dart
index 7aebc8148b8376debc1ce000f9f6979820170d61..3add11599f9bc002ff233fe44aa5105ce22f01ac 100644
--- a/runtime/observatory/lib/service_common.dart
+++ b/runtime/observatory/lib/service_common.dart
@@ -203,6 +203,12 @@ abstract class CommonWebSocketVM extends VM {
Logger.root.severe('Received unexpected message: ${map}');
return;
}
+ if (request.method != 'getTagProfile' &&
+ request.method != 'getIsolateMetric' &&
+ request.method != 'getVMMetric') {
+ Logger.root.info(
+ 'RESPONSE [${serial}] ${request.method}');
+ }
request.completer.complete(response);
}
@@ -260,11 +266,6 @@ abstract class CommonWebSocketVM extends VM {
/// Send the request over WebSocket.
void _sendRequest(String serial, _WebSocketRequest request) {
assert (_webSocket.isOpen);
- if (request.method != 'getTagProfile' &&
- request.method != 'getIsolateMetric' &&
- request.method != 'getVMMetric') {
- Logger.root.info('GET ${request.method} from ${target.networkAddress}');
- }
// Mark request as pending.
assert(_pendingRequests.containsKey(serial) == false);
_pendingRequests[serial] = request;
@@ -284,6 +285,12 @@ abstract class CommonWebSocketVM extends VM {
'method': request.method,
'params': request.params});
}
+ if (request.method != 'getTagProfile' &&
+ request.method != 'getIsolateMetric' &&
+ request.method != 'getVMMetric') {
+ Logger.root.info(
+ 'GET [${serial}] ${request.method} from ${target.networkAddress}');
+ }
// Send message.
_webSocket.send(message);
}
« no previous file with comments | « runtime/bin/vmservice/server.dart ('k') | runtime/observatory/lib/src/cli/command.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698