dart2js: Handle zero-terminated content explicitly.

dart2js: Handle zero-terminated content explicitly.

BUG= http://dartbug.com/22667
R=ajohnsen@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44427

[floitsch, 2015-03-10 20:57:20]

floitsch@google.com changed reviewers:
+ ajohnsen@google.com, johnniwinther@google.com

[floitsch, 2015-03-10 20:57:20]

Still needs a test.

Obsoletes https://codereview.chromium.org/989113007

[Anders Johnsen, 2015-03-11 08:06:01]

LGTM!

https://codereview.chromium.org/992333003/diff/1/tests/compiler/dart2js/scann...
File tests/compiler/dart2js/scanner_test.dart (right):

https://codereview.chromium.org/992333003/diff/1/tests/compiler/dart2js/scann...
tests/compiler/dart2js/scanner_test.dart:11: List<int> zeroTerminated = new
List<int>(bytes.length + 1);
uint8list?

[Johnni Winther, 2015-03-11 08:35:20]

lgtm

[floitsch, 2015-03-11 17:07:12]

I added a test.
PTAL.

https://chromiumcodereview.appspot.com/992333003/diff/1/tests/compiler/dart2j...
File tests/compiler/dart2js/scanner_test.dart (right):

https://chromiumcodereview.appspot.com/992333003/diff/1/tests/compiler/dart2j...
tests/compiler/dart2js/scanner_test.dart:11: List<int> zeroTerminated = new
List<int>(bytes.length + 1);
On 2015/03/11 08:06:01, Anders Johnsen wrote:
> uint8list?

Done.

[Anders Johnsen, 2015-03-12 08:12:05]

LGTM,

But, the test setup looks really complicated for what I would have assumed was
simple :/

[floitsch, 2015-03-12 12:31:37]

On 2015/03/12 08:12:05, Anders Johnsen wrote:
> LGTM,
> 
> But, the test setup looks really complicated for what I would have assumed was
> simple :/

It's probably overkill, but this way we really reproduce the bug that was filed.

[floitsch, 2015-03-12 12:33:12]

Committed patchset #3 (id:40001) manually as 44427 (presubmit successful).