Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 989113007: Don't include the trailing \0 of input bytes, in the string representation of source files. (Closed)

Created:
5 years, 9 months ago by Anders Johnsen
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Don't include the trailing \0 of input bytes, in the string representation of source files. The trailing \0 is an artifact of reading the input source into a buffer of the size + 1. The \0 is then used by the scanner to identify the end of the file. BUG=https://code.google.com/p/dart/issues/detail?id=22667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/compiler/lib/src/io/source_file.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Anders Johnsen
5 years, 9 months ago (2015-03-09 20:55:31 UTC) #2
Feel free to hijack this CL, if there is a better way to fix this.

Powered by Google App Engine
This is Rietveld 408576698