Add CacheEntry.setErrorState().

Add CacheEntry.setErrorState().

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=44309

[Brian Wilkerson, 2015-03-07 15:43:32]

LGTM

https://codereview.chromium.org/988883004/diff/1/pkg/analyzer/lib/src/context...
File pkg/analyzer/lib/src/context/cache.dart (right):

https://codereview.chromium.org/988883004/diff/1/pkg/analyzer/lib/src/context...
pkg/analyzer/lib/src/context/cache.dart:356: List<ResultDescriptor> descriptors,
CaughtException exception) {
I would prefer having the exception be the first argument. I think that client
code formats better when variable length arguments (such as list literals) can
be placed at the end of the argument list.

[scheglov, 2015-03-07 17:01:04]

https://codereview.chromium.org/988883004/diff/1/pkg/analyzer/lib/src/context...
File pkg/analyzer/lib/src/context/cache.dart (right):

https://codereview.chromium.org/988883004/diff/1/pkg/analyzer/lib/src/context...
pkg/analyzer/lib/src/context/cache.dart:356: List<ResultDescriptor> descriptors,
CaughtException exception) {
On 2015/03/07 15:43:32, Brian Wilkerson wrote:
> I would prefer having the exception be the first argument. I think that client
> code formats better when variable length arguments (such as list literals) can
> be placed at the end of the argument list.

Done.

[scheglov, 2015-03-07 17:01:39]

Committed patchset #1 (id:1) manually as 44309 (presubmit successful).