Add CacheEntry.setErrorState().

pkg/analyzer/test/src/context/cache_test.dart

Index: pkg/analyzer/test/src/context/cache_test.dart
diff --git a/pkg/analyzer/test/src/context/cache_test.dart b/pkg/analyzer/test/src/context/cache_test.dart
index b5ff24a8561a04408c5c0343e463bfe11bbeebe7..e763e2a308a4df1cfbd935348568238aa726fbf9 100644
--- a/pkg/analyzer/test/src/context/cache_test.dart
+++ b/pkg/analyzer/test/src/context/cache_test.dart
@@ -159,28 +159,22 @@ class CacheEntryTest extends EngineTestCase {
     ResultDescriptor result = new ResultDescriptor('test', null);
     CaughtException exception = new CaughtException(null, null);
     CacheEntry entry = new CacheEntry();
-    entry.setState(result, CacheState.ERROR);
-    entry.exception = exception;
+    entry.setErrorState(<ResultDescriptor>[result], exception);
     entry.fixExceptionState();
     expect(entry.getState(result), CacheState.ERROR);
     expect(entry.exception, exception);
   }
 
-  test_fixExceptionState_error_noException() {
-    ResultDescriptor result = new ResultDescriptor('test', null);
-    CacheEntry entry = new CacheEntry();
-    entry.setState(result, CacheState.ERROR);
-    entry.fixExceptionState();
-    expect(entry.getState(result), CacheState.ERROR);
-    expect(entry.exception, isNotNull);
-  }
-
   test_fixExceptionState_noError_exception() {
     ResultDescriptor result = new ResultDescriptor('test', null);
     CacheEntry entry = new CacheEntry();
-    entry.exception = new CaughtException(null, null);
+    // set one result to ERROR
+    CaughtException exception = new CaughtException(null, null);
+    entry.setErrorState(<ResultDescriptor>[result], exception);
+    // set the same result to VALID
+    entry.setValue(result, 1);
+    // fix the exception state
     entry.fixExceptionState();
-    expect(entry.getState(result), CacheState.INVALID);
     expect(entry.exception, isNull);
   }
 
@@ -233,8 +227,9 @@ class CacheEntryTest extends EngineTestCase {
 
   test_hasErrorState_true() {
     ResultDescriptor result = new ResultDescriptor('test', null);
+    CaughtException exception = new CaughtException(null, null);
     CacheEntry entry = new CacheEntry();
-    entry.setState(result, CacheState.ERROR);
+    entry.setErrorState(<ResultDescriptor>[result], exception);
     expect(entry.hasErrorState(), true);
   }
 
@@ -247,20 +242,94 @@ class CacheEntryTest extends EngineTestCase {
     expect(entry.getValue(result), isNull);
   }
 
+  test_setErrorState() {
+    ResultDescriptor result1 = new ResultDescriptor('res1', 1);
+    ResultDescriptor result2 = new ResultDescriptor('res2', 2);
+    ResultDescriptor result3 = new ResultDescriptor('res3', 3);
+    // prepare some good state
+    CacheEntry entry = new CacheEntry();
+    entry.setValue(result1, 10);
+    entry.setValue(result2, 20);
+    entry.setValue(result3, 30);
+    // set error state
+    CaughtException exception = new CaughtException(null, null);
+    entry.setErrorState(<ResultDescriptor>[result1, result2], exception);
+    // verify
+    expect(entry.exception, exception);
+    expect(entry.getState(result1), CacheState.ERROR);
+    expect(entry.getState(result2), CacheState.ERROR);
+    expect(entry.getState(result3), CacheState.VALID);
+    expect(entry.getValue(result1), 1);
+    expect(entry.getValue(result2), 2);
+    expect(entry.getValue(result3), 30);
+  }
+
+  test_setErrorState_noDescriptors() {
+    CaughtException exception = new CaughtException(null, null);
+    CacheEntry entry = new CacheEntry();
+    expect(() {
+      entry.setErrorState(<ResultDescriptor>[], exception);
+    }, throwsArgumentError);
+  }
+
+  test_setErrorState_noException() {
+    ResultDescriptor result = new ResultDescriptor('test', null);
+    CacheEntry entry = new CacheEntry();
+    expect(() {
+      entry.setErrorState(<ResultDescriptor>[result], null);
+    }, throwsArgumentError);
+  }
+
   test_setState_error() {
     ResultDescriptor result = new ResultDescriptor('test', null);
     CacheEntry entry = new CacheEntry();
-    entry.setState(result, CacheState.ERROR);
-    expect(entry.getState(result), CacheState.ERROR);
-    expect(entry.getValue(result), isNull);
+    entry.setValue(result, 42);
+    // an invalid state change
+    expect(() {
+      entry.setState(result, CacheState.ERROR);
+    }, throwsArgumentError);
+    // no changes
+    expect(entry.getState(result), CacheState.VALID);
+    expect(entry.getValue(result), 42);
+  }
+
+  test_setState_flushed() {
+    ResultDescriptor result = new ResultDescriptor('test', 1);
+    CacheEntry entry = new CacheEntry();
+    // set VALID
+    entry.setValue(result, 10);
+    expect(entry.getState(result), CacheState.VALID);
+    expect(entry.getValue(result), 10);
+    // set FLUSHED
+    entry.setState(result, CacheState.FLUSHED);
+    expect(entry.getState(result), CacheState.FLUSHED);
+    expect(entry.getValue(result), 1);
+  }
+
+  test_setState_inProcess() {
+    ResultDescriptor result = new ResultDescriptor('test', 1);
+    CacheEntry entry = new CacheEntry();
+    // set VALID
+    entry.setValue(result, 10);
+    expect(entry.getState(result), CacheState.VALID);
+    expect(entry.getValue(result), 10);
+    // set IN_PROCESS
+    entry.setState(result, CacheState.IN_PROCESS);
+    expect(entry.getState(result), CacheState.IN_PROCESS);
+    expect(entry.getValue(result), 10);
   }
 
   test_setState_invalid() {
-    ResultDescriptor result = new ResultDescriptor('test', null);
+    ResultDescriptor result = new ResultDescriptor('test', 1);
     CacheEntry entry = new CacheEntry();
+    // set VALID
+    entry.setValue(result, 10);
+    expect(entry.getState(result), CacheState.VALID);
+    expect(entry.getValue(result), 10);
+    // set INVALID
     entry.setState(result, CacheState.INVALID);
     expect(entry.getState(result), CacheState.INVALID);
-    expect(entry.getValue(result), isNull);
+    expect(entry.getValue(result), 1);
   }
 
   test_setState_valid() {