Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 987043002: dart2js: replace null in arrays with array holes in type representations. (Closed)

Created:
5 years, 9 months ago by zarah
Modified:
5 years, 9 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: replace null in arrays with array holes in type representations. R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=44361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +6 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zarah
5 years, 9 months ago (2015-03-09 13:22:20 UTC) #2
herhut
LGTM!
5 years, 9 months ago (2015-03-09 13:53:56 UTC) #3
zarah
5 years, 9 months ago (2015-03-10 09:22:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44361 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698