Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: tests/compiler/dart2js/type_representation_test.dart

Issue 987043002: dart2js: replace null in arrays with array holes in type representations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/runtime_types.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/type_representation_test.dart
diff --git a/tests/compiler/dart2js/type_representation_test.dart b/tests/compiler/dart2js/type_representation_test.dart
index d1c5c9359bacb0a42fbf869a44d14a876e0b531b..cce69d198f75f32cbb933b4cbcbfd4a81549ef0c 100644
--- a/tests/compiler/dart2js/type_representation_test.dart
+++ b/tests/compiler/dart2js/type_representation_test.dart
@@ -169,9 +169,9 @@ void testTypeRepresentations() {
' $typedefTag: $Typedef6_rep}]');
expect(instantiate(List_, [Typedef7_]),
'[$List_rep, {$func: "dynamic__int_String__List_dynamic", $args: '
- '[$int_rep, $String_rep], $opt: [[$List_rep, $int_rep], null]}]',
+ '[$int_rep, $String_rep], $opt: [[$List_rep, $int_rep],,]}]',
'[$List_rep, {$func: "dynamic__int_String__List_dynamic", $args: '
- '[$int_rep, $String_rep], $opt: [[$List_rep, $int_rep], null], '
+ '[$int_rep, $String_rep], $opt: [[$List_rep, $int_rep],,], '
'$typedefTag: $Typedef7_rep}]');
expect(instantiate(List_, [Typedef8_]),
'[$List_rep, {$func: "dynamic__int__String0", $args: [$int_rep],'
@@ -188,10 +188,10 @@ void testTypeRepresentations() {
expect(instantiate(List_, [Typedef10_]),
'[$List_rep, {$func: "dynamic__void__int__dynamic", '
'$args: [{$func: "void__int__dynamic", $retvoid: true, '
- '$args: [$int_rep], $opt: [null]}]}]',
+ '$args: [$int_rep], $opt: [,]}]}]',
'[$List_rep, {$func: "dynamic__void__int__dynamic", '
'$args: [{$func: "void__int__dynamic", $retvoid: true, '
- '$args: [$int_rep], $opt: [null]}], $typedefTag: $Typedef10_rep}]');
+ '$args: [$int_rep], $opt: [,]}], $typedefTag: $Typedef10_rep}]');
// Map<K,V>
expect(Map_.computeType(env.compiler),
@@ -234,7 +234,7 @@ void testTypeRepresentations() {
expect(env.getElement('m7').computeType(env.compiler),
'{$func: "dynamic__int_String__List_dynamic",'
' $args: [$int_rep, $String_rep],'
- ' $opt: [[$List_rep, $int_rep], null]}');
+ ' $opt: [[$List_rep, $int_rep],,]}');
// m8(int a, {String b}) {}
expect(env.getElement('m8').computeType(env.compiler),
@@ -251,6 +251,6 @@ void testTypeRepresentations() {
expect(env.getElement('m10').computeType(env.compiler),
'{$func: "dynamic__void__int__dynamic", $args:'
' [{$func: "void__int__dynamic",'
- ' $retvoid: true, $args: [$int_rep], $opt: [null]}]}');
+ ' $retvoid: true, $args: [$int_rep], $opt: [,]}]}');
}));
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/runtime_types.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698