Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 98663003: Don't emit unused hints when there are compilation errors. (Closed)

Created:
7 years ago by ahe
Modified:
7 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't emit unused hints when there are compilation errors. Also, revert "Ignore unused hints." (r30795). R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=30796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/compiler.dart View 2 chunks +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
7 years ago (2013-12-02 13:59:26 UTC) #1
Johnni Winther
lgtm
7 years ago (2013-12-02 13:59:55 UTC) #2
ahe
7 years ago (2013-12-02 14:38:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698