Issue 984463002: Improve the formatting of strings that contain unprintable ASCII characters.

Issue 984463002: Improve the formatting of strings that contain unprintable ASCII characters. (Closed)

Created:
5 years, 9 months ago by nweiz

Modified:
5 years, 9 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/matcher@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Improve the formatting of strings that contain unprintable ASCII characters. R=kevmoo@google.com Committed: https://github.com/dart-lang/matcher/commit/db1c5eacb91f5e2fe4d4403a68367717acf3a81d

Patch Set 2 : Code review changes #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -7 lines)			Patch
M	CHANGELOG.md	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/src/util.dart	View	1	2 chunks	+7 lines, -4 lines	0 comments	Download
M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/escape_test.dart	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/984463002/diff/1/lib/src/util.dart File lib/src/util.dart (right): https://codereview.chromium.org/984463002/diff/1/lib/src/util.dart#newcode18 lib/src/util.dart:18: '\v': r'\v', double entry? https://codereview.chromium.org/984463002/diff/1/lib/src/util.dart#newcode19 lib/src/util.dart:19: '\x7F': r'\x7F', ...

5 years, 9 months ago (2015-03-04 23:07:29 UTC) #2

nweiz

https://codereview.chromium.org/984463002/diff/1/lib/src/util.dart File lib/src/util.dart (right): https://codereview.chromium.org/984463002/diff/1/lib/src/util.dart#newcode18 lib/src/util.dart:18: '\v': r'\v', On 2015/03/04 23:07:29, kevmoo wrote: > double ...

5 years, 9 months ago (2015-03-05 00:50:12 UTC) #4

nweiz

5 years, 9 months ago (2015-03-05 00:51:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
db1c5eacb91f5e2fe4d4403a68367717acf3a81d (presubmit successful).

Expand Messages | Collapse Messages