Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: test/escape_test.dart

Issue 984463002: Improve the formatting of strings that contain unprintable ASCII characters. (Closed) Base URL: git@github.com:dart-lang/matcher@master
Patch Set: Code review changes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pubspec.yaml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library matcher.escape_test; 5 library matcher.escape_test;
6 6
7 import 'package:matcher/src/util.dart'; 7 import 'package:matcher/src/util.dart';
8 import 'package:unittest/unittest.dart'; 8 import 'package:unittest/unittest.dart';
9 9
10 void main() { 10 void main() {
11 group('escaping should work with', () { 11 group('escaping should work with', () {
12 _testEscaping('no escaped chars', 'Hello, world!', 'Hello, world!'); 12 _testEscaping('no escaped chars', 'Hello, world!', 'Hello, world!');
13 _testEscaping('newline', '\n', r'\n'); 13 _testEscaping('newline', '\n', r'\n');
14 _testEscaping('carriage return', '\r', r'\r'); 14 _testEscaping('carriage return', '\r', r'\r');
15 _testEscaping('form feed', '\f', r'\f'); 15 _testEscaping('form feed', '\f', r'\f');
16 _testEscaping('backspace', '\b', r'\b'); 16 _testEscaping('backspace', '\b', r'\b');
17 _testEscaping('tab', '\t', r'\t'); 17 _testEscaping('tab', '\t', r'\t');
18 _testEscaping('vertical tab', '\v', r'\v'); 18 _testEscaping('vertical tab', '\v', r'\v');
19 _testEscaping('null byte', '\x00', r'\x00');
20 _testEscaping('ASCII control character', '\x11', r'\x11');
21 _testEscaping('delete', '\x7F', r'\x7F');
19 _testEscaping('escape combos', r'\n', r'\\n'); 22 _testEscaping('escape combos', r'\n', r'\\n');
20 _testEscaping('All characters', 23 _testEscaping('All characters',
21 'A new line\nA charriage return\rA form feed\fA backspace\b' 24 'A new line\nA charriage return\rA form feed\fA backspace\b'
22 'A tab\tA vertical tab\vA slash\\', 25 'A tab\tA vertical tab\vA slash\\A null byte\x00A control char\x1D'
26 'A delete\x7F',
23 r'A new line\nA charriage return\rA form feed\fA backspace\b' 27 r'A new line\nA charriage return\rA form feed\fA backspace\b'
24 r'A tab\tA vertical tab\vA slash\\'); 28 r'A tab\tA vertical tab\vA slash\\A null byte\x00A control char\x1D'
29 r'A delete\x7F');
25 }); 30 });
26 31
27 group('unequal strings remain unequal when escaped', () { 32 group('unequal strings remain unequal when escaped', () {
28 _testUnequalStrings('with a newline', '\n', r'\n'); 33 _testUnequalStrings('with a newline', '\n', r'\n');
29 _testUnequalStrings('with slash literals', '\\', r'\\'); 34 _testUnequalStrings('with slash literals', '\\', r'\\');
30 }); 35 });
31 } 36 }
32 37
33 /// Creates a [test] with name [name] that verifies [source] escapes to value 38 /// Creates a [test] with name [name] that verifies [source] escapes to value
34 /// [target]. 39 /// [target].
(...skipping 14 matching lines...) Expand all
49 expect(s1 != s2, isTrue, reason: 'The source values should be unequal'); 54 expect(s1 != s2, isTrue, reason: 'The source values should be unequal');
50 55
51 var escapedS1 = escape(s1); 56 var escapedS1 = escape(s1);
52 var escapedS2 = escape(s2); 57 var escapedS2 = escape(s2);
53 58
54 // Explicitly not using the equals matcher 59 // Explicitly not using the equals matcher
55 expect(escapedS1 != escapedS2, isTrue, 60 expect(escapedS1 != escapedS2, isTrue,
56 reason: 'Unequal strings, when escaped, should remain unequal.'); 61 reason: 'Unequal strings, when escaped, should remain unequal.');
57 }); 62 });
58 } 63 }
OLDNEW
« no previous file with comments | « pubspec.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698