Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 982983003: remove type suggestion when interpolation completion (Closed)

Created:
5 years, 9 months ago by danrubel
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

remove type suggestion when interpolation completion BUG=dartbug.com/21518 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44276

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -177 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 5 chunks +21 lines, -21 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 3 chunks +147 lines, -145 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/optype.dart View 2 chunks +3 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +60 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 9 months ago (2015-03-05 22:59:54 UTC) #2
scheglov
LGTM
5 years, 9 months ago (2015-03-06 00:28:34 UTC) #3
danrubel
5 years, 9 months ago (2015-03-06 01:58:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44276 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698