Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: pkg/analysis_server/lib/src/services/completion/optype.dart

Issue 982983003: remove type suggestion when interpolation completion (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/optype.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/optype.dart b/pkg/analysis_server/lib/src/services/completion/optype.dart
index 197ffbaaf48a55eb05b88582ce249dbff56c0076..96b89bf64a0b232228f3fb580c7c3911bf9348db 100644
--- a/pkg/analysis_server/lib/src/services/completion/optype.dart
+++ b/pkg/analysis_server/lib/src/services/completion/optype.dart
@@ -72,13 +72,6 @@ class OpType {
!includeReturnValueSuggestions &&
!includeVoidReturnSuggestions &&
!includeInvocationSuggestions;
-
- /**
- * Indicate whether top level elements should be suggested
- */
- bool get includeTopLevelSuggestions => includeReturnValueSuggestions ||
- includeTypeNameSuggestions ||
- includeVoidReturnSuggestions;
}
class _OpTypeAstVisitor extends GeneralizingAstVisitor {
@@ -359,7 +352,9 @@ class _OpTypeAstVisitor extends GeneralizingAstVisitor {
void visitInterpolationExpression(InterpolationExpression node) {
if (identical(entity, node.expression)) {
optype.includeReturnValueSuggestions = true;
- optype.includeTypeNameSuggestions = true;
+ // Only include type names in a ${ } expression
+ optype.includeTypeNameSuggestions =
+ node.leftBracket != null && node.leftBracket.length > 1;
}
}

Powered by Google App Engine
This is Rietveld 408576698