Major rework of vm service events.

Major rework of vm service events

--------
VM

Add a new ServiceEvent class in the vm.  Rework the event type names.

Add BreakpointAdded, BreakpointResolved, and BreakpointRemoved
service events.

Record the top frame for kIsolateInterrupted and kExceptionThrown
debugger events.

Send a top frame in more Pause* events.

Send breakpoint list with the Isolate response.  Remove the
getBreakpoints method from the vm service.

Move Resume events into debugger.cc.

Rework MessageHandler a bit so that we can send PauseStart and
PauseExit notifications.

--------
Observatory

Move some event handler from Application to Isolate.

Rewrite breakpoint tracking code to use the new breakpoint events.

Change run state tracking in Isolate.

Change getFromMap so that it applies updates if the map isn't a ref.

Use getFromMap instead of new ServiceObject in invokeRpc.  This
fixes some duplicate ServiceObject problems.

Committed: https://code.google.com/p/dart/source/detail?r=44268

[turnidge, 2015-03-04 21:32:32]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-03-05 16:30:57]

LGTMwC

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/debugger.dart:145: if (event.eventType ==
'PauseStart') {
These event type strings should be collected in object.dart, something like:

final kPauseStartEvent = 'PauseStart';

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/script_ref.dart (right):

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/script_ref.dart:41: return
'${super.name}:${script.tokenToLine(pos)}:${script.tokenToCol(pos)}';
80 column limit

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/service/object.dart:1068: 'Isolate lifecycle event
should not be delivered to isolate');
Throw here.

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/service/object.dart:1495: assert(number == null ||
number == newNumber);
Wrap comparisons in ( ) here and elsewhere.

e.g. ((number == null) || (number == newNumber))

https://codereview.chromium.org/979823003/diff/60001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/979823003/diff/60001/runtime/vm/debugger.cc#n...
runtime/vm/debugger.cc:237: event->type() != DebuggerEvent::kBreakpointResolved)
{
(event->type() != DebuggerEvent::kBreakpointResolved)

[turnidge, 2015-03-05 18:42:24]

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/debugger.dart:145: if (event.eventType ==
'PauseStart') {
On 2015/03/05 16:30:57, Cutch wrote:
> These event type strings should be collected in object.dart, something like:
> 
> final kPauseStartEvent = 'PauseStart';

Done.

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/script_ref.dart (right):

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/script_ref.dart:41: return
'${super.name}:${script.tokenToLine(pos)}:${script.tokenToCol(pos)}';
On 2015/03/05 16:30:57, Cutch wrote:
> 80 column limit

Done.

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/service/object.dart:1068: 'Isolate lifecycle event
should not be delivered to isolate');
On 2015/03/05 16:30:57, Cutch wrote:
> Throw here.

Turned this into an assert.

https://codereview.chromium.org/979823003/diff/60001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/979823003/diff/60001/runtime/vm/debugger.cc#n...
runtime/vm/debugger.cc:237: event->type() != DebuggerEvent::kBreakpointResolved)
{
On 2015/03/05 16:30:57, Cutch wrote:
> (event->type() != DebuggerEvent::kBreakpointResolved)

Done.

[turnidge, 2015-03-05 18:43:14]

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/979823003/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/service/object.dart:1495: assert(number == null ||
number == newNumber);
On 2015/03/05 16:30:57, Cutch wrote:
> Wrap comparisons in ( ) here and elsewhere.
> 
> e.g. ((number == null) || (number == newNumber))

Done.

[turnidge, 2015-03-05 19:03:43]

Committed patchset #6 (id:100001) manually as 44268 (presubmit successful).