Major rework of vm service events.

runtime/observatory/lib/src/app/application.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of app;
 
 /// The observatory application. Instances of this are created and owned
 /// by the observatory_application custom element.
 class ObservatoryApplication extends Observable {
   static ObservatoryApplication app;
@@ skipping 33 matching lines @@
 
   void _initOnce(bool chromium) {
     assert(app == null);
     app = this;
     _registerPages();
     locationManager._init(this);
   }
 
   void removePauseEvents(Isolate isolate) {
     bool isPauseEvent(var event) {
-      return (event.eventType == 'IsolateInterrupted' ||
-              event.eventType == 'BreakpointReached' ||
-              event.eventType == 'ExceptionThrown');
+      return (event.eventType == ServiceEvent.kPauseStart ||
+              event.eventType == ServiceEvent.kPauseExit ||
+              event.eventType == ServiceEvent.kPauseBreakpoint ||
+              event.eventType == ServiceEvent.kPauseInterrupted ||
+              event.eventType == ServiceEvent.kPauseException);
     }
 
     notifications.removeWhere((oldEvent) {
         return (oldEvent.isolate == isolate &&
                 isPauseEvent(oldEvent));
       });
   }
 
   void _onEvent(ServiceEvent event) {
     switch(event.eventType) {
-      case 'IsolateCreated':
+      case ServiceEvent.kIsolateStart:
+      case ServiceEvent.kGraph:
+      case ServiceEvent.kBreakpointAdded:
+      case ServiceEvent.kBreakpointResolved:
+      case ServiceEvent.kBreakpointRemoved:
+      case ServiceEvent.kGC:
         // Ignore for now.
         break;
 
-      case 'IsolateResumed':
-        event.isolate.pauseEvent = null;
+      case ServiceEvent.kIsolateExit:
+      case ServiceEvent.kResume:
+        removePauseEvents(event.isolate);
         break;
 
-      case 'IsolateShutdown':
-        // TODO(turnidge): Should we show the user isolate shutdown events?
-        // What if there are hundreds of them?  Coalesce multiple
-        // shutdown events into one notification?
-        removePauseEvents(event.isolate);
-
-        // TODO(turnidge): Reload the isolate for now in case it is
-        // paused.  We may need to distinguish an IsolateShutdown
-        // event from a "paused at isolate shutdown" event.
-        event.isolate.reload();
-        break;
-
-      case 'BreakpointResolved':
-        event.isolate.reloadBreakpoints();
-        break;
-
-      case 'BreakpointReached':
-      case 'IsolateInterrupted':
-      case 'ExceptionThrown':
-        event.isolate.pauseEvent = event;
+      case ServiceEvent.kPauseStart:
+      case ServiceEvent.kPauseExit:
+      case ServiceEvent.kPauseBreakpoint:
+      case ServiceEvent.kPauseInterrupted:
+      case ServiceEvent.kPauseException:
         removePauseEvents(event.isolate);
         notifications.add(event);
         break;
 
-      case '_Graph':
-        event.isolate.loadHeapSnapshot(event);
-        break;
-
-      case 'GC':
-        // Ignore GC events for now.
-        break;
-
       default:
         // Ignore unrecognized events.
         Logger.root.severe('Unrecognized event: $event');
         break;
     }
   }
 
   void _registerPages() {
     _pageRegistry.add(new VMPage(this));
     _pageRegistry.add(new FlagsPage(this));
@@ skipping 93 matching lines @@
 
   ObservatoryApplication(this.rootElement) :
       locationManager = new HashLocationManager(),
       targets = new TargetManager() {
     vm = new WebSocketVM(targets.defaultTarget);
     _initOnce(false);
   }
 
   void _removeDisconnectEvents() {
     notifications.removeWhere((oldEvent) {
-        return (oldEvent.eventType == 'VMDisconnected');
+        return (oldEvent.eventType == ServiceEvent.kVMDisconnected);
       });
   }
 
   _vmConnected(VM vm) {
     if (vm is WebSocketVM) {
       targets.add(vm.target);
     }
     _removeDisconnectEvents();
   }
 
   _vmDisconnected(VM vm) {
     if (this.vm != vm) {
       // This disconnect event occured *after* a new VM was installed.
       return;
     }
     this.vm = null;
     notifications.add(new ServiceEvent.vmDisconencted());
   }
 }