Display call site data for functions.

Display call site data for functions.

 - Requested with coverage data, only in function view for now.
 - Adjust token position associated with ICData to correspond to the identifier instead of the open paren.
 - Fix JSONifying ICs for static/constructor calls.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44476

[rmacnak, 2015-03-05 02:11:28]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[rmacnak, 2015-03-05 02:11:28]

https://codereview.chromium.org/977283002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/977283002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:11910: cache_entry.AddProperty("receiverClass",
Library::Handle(cls.library()));
Weird.

[Cutch, 2015-03-09 18:22:43]

https://codereview.chromium.org/977283002/diff/1/runtime/observatory/lib/src/...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/977283002/diff/1/runtime/observatory/lib/src/...
runtime/observatory/lib/src/service/object.dart:2057: final int column;
Can we store tokenPos and script instead?

https://codereview.chromium.org/977283002/diff/1/runtime/observatory/lib/src/...
runtime/observatory/lib/src/service/object.dart:2081: class CallSiteEntry {
Maybe rename to InstanceCall?

abstract class Call {
  int count;
}

class InstanceCall extends Call {
  Class receiver;
}

https://codereview.chromium.org/977283002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/977283002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:11910: cache_entry.AddProperty("receiverClass",
Library::Handle(cls.library()));
rename to 'receiver'?

[rmacnak, 2015-03-09 23:16:02]

https://codereview.chromium.org/977283002/diff/1/runtime/observatory/lib/src/...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/977283002/diff/1/runtime/observatory/lib/src/...
runtime/observatory/lib/src/service/object.dart:2057: final int column;
On 2015/03/09 18:22:42, Cutch wrote:
> Can we store tokenPos and script instead?

Done.

https://codereview.chromium.org/977283002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/977283002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:11910: cache_entry.AddProperty("receiverClass",
Library::Handle(cls.library()));
On 2015/03/09 18:22:42, Cutch wrote:
> rename to 'receiver'?

It's not the receiver (i.e. an instance). The source mirrors name a
class-or-library a container, so how about receiverContainer?

[Cutch, 2015-03-13 16:44:30]

lgtm

[rmacnak, 2015-03-13 20:47:10]

Committed patchset #2 (id:20001) manually as 44476 (presubmit successful).